From owner-freebsd-bugs@FreeBSD.ORG Tue Nov 29 13:30:12 2011 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id EE67F1065675 for ; Tue, 29 Nov 2011 13:30:12 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id AA3308FC15 for ; Tue, 29 Nov 2011 13:30:12 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id pATDUCLZ027718 for ; Tue, 29 Nov 2011 13:30:12 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.5/8.14.5/Submit) id pATDUC66027717; Tue, 29 Nov 2011 13:30:12 GMT (envelope-from gnats) Resent-Date: Tue, 29 Nov 2011 13:30:12 GMT Resent-Message-Id: <201111291330.pATDUC66027717@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Matthieu Kraus Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 81F13106564A for ; Tue, 29 Nov 2011 13:22:12 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22]) by mx1.freebsd.org (Postfix) with ESMTP id 713738FC0A for ; Tue, 29 Nov 2011 13:22:12 +0000 (UTC) Received: from red.freebsd.org (localhost [127.0.0.1]) by red.freebsd.org (8.14.4/8.14.4) with ESMTP id pATDMB54032760 for ; Tue, 29 Nov 2011 13:22:11 GMT (envelope-from nobody@red.freebsd.org) Received: (from nobody@localhost) by red.freebsd.org (8.14.4/8.14.4/Submit) id pATDMB4g032741; Tue, 29 Nov 2011 13:22:11 GMT (envelope-from nobody) Message-Id: <201111291322.pATDMB4g032741@red.freebsd.org> Date: Tue, 29 Nov 2011 13:22:11 GMT From: Matthieu Kraus To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Cc: Subject: kern/162947: pfsync_defer return ignored with __FreeBSD__ X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 29 Nov 2011 13:30:13 -0000 >Number: 162947 >Category: kern >Synopsis: pfsync_defer return ignored with __FreeBSD__ >Confidential: no >Severity: serious >Priority: medium >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Tue Nov 29 13:30:12 UTC 2011 >Closed-Date: >Last-Modified: >Originator: Matthieu Kraus >Release: FreeBSD 10.0-CURRENT arm >Organization: >Environment: FreeBSD dreamplug 10.0-CURRENT FreeBSD 10.0-CURRENT #1 r228127M: Tue Nov 29 12:15:21 UTC 2011 root@dreamplug:/usr/obj/us r/src/sys/DREAMPLUG arm >Description: similiar to the recent issue that caused pf to leak states due to discarding the wanted return of a function, this one seems ver y similiar and seemed to cause slowly leaking mbufs for me (not sure how to verify it's exactly that) >How-To-Repeat: have device pfsync enabled in the kernel config >Fix: see attached patch Patch attached with submission follows: Index: sys/contrib/pf/net/pf.c =================================================================== --- sys/contrib/pf/net/pf.c (revision 228127) +++ sys/contrib/pf/net/pf.c (working copy) @@ -3770,8 +3770,8 @@ * replies through it. */ #ifdef __FreeBSD__ - if (pfsync_defer_ptr != NULL) - pfsync_defer_ptr(*sm, m); + if (pfsync_defer_ptr != NULL && + pfsync_defer_ptr(*sm, m)) #else if (pfsync_defer(*sm, m)) #endif >Release-Note: >Audit-Trail: >Unformatted: