From owner-freebsd-scsi Fri Sep 18 10:46:04 1998 Return-Path: Received: (from majordom@localhost) by hub.freebsd.org (8.8.8/8.8.8) id KAA27049 for freebsd-scsi-outgoing; Fri, 18 Sep 1998 10:46:04 -0700 (PDT) (envelope-from owner-freebsd-scsi@FreeBSD.ORG) Received: from ns1.yes.no (ns1.yes.no [195.119.24.10]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id KAA26985 for ; Fri, 18 Sep 1998 10:46:00 -0700 (PDT) (envelope-from eivind@bitbox.follo.net) Received: from bitbox.follo.net (bitbox.follo.net [195.204.143.218]) by ns1.yes.no (8.9.1a/8.9.1) with ESMTP id TAA00998; Fri, 18 Sep 1998 19:45:34 +0200 (CEST) Received: (from eivind@localhost) by bitbox.follo.net (8.8.8/8.8.6) id TAA16855; Fri, 18 Sep 1998 19:45:34 +0200 (MET DST) Message-ID: <19980918194533.52865@follo.net> Date: Fri, 18 Sep 1998 19:45:33 +0200 From: Eivind Eklund To: "Kenneth D. Merry" Cc: scsi@FreeBSD.ORG Subject: Re: Fixing LINT References: <19980918184204.00622@follo.net> <199809181707.LAA10835@panzer.plutotech.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Mailer: Mutt 0.89.1i In-Reply-To: <199809181707.LAA10835@panzer.plutotech.com>; from Kenneth D. Merry on Fri, Sep 18, 1998 at 11:07:22AM -0600 Sender: owner-freebsd-scsi@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.org On Fri, Sep 18, 1998 at 11:07:22AM -0600, Kenneth D. Merry wrote: > Eivind Eklund wrote... > > The following patch fix LINT to compile again. Anybody here that mind > > if I commit it? > > A number of these are wrong: No. All of them were necessary to get LINT to compile and link. > > =================================================================== > > RCS file: /home/ncvs/src/sys/i386/conf/LINT,v > > retrieving revision 1.470 > > diff -u -r1.470 LINT > > --- LINT 1998/09/18 00:46:41 1.470 > > +++ LINT 1998/09/18 16:25:21 > > @@ -879,19 +879,19 @@ > > # > > > > controller bt0 at isa? port "IO_BT0" cam irq ? > > -controller adv0 at isa? port ? cam irq ? > > AdvanSys controllers are supported under CAM. It doesn't link. (This is first-order due to a commented out part of files.i386, IIRC). > > -controller aha0 at isa? port "IO_AHA0" bio irq ? drq 5 vector ahaintr > > The Adaptec 154x controllers are also supported under CAM. It doesn't link, either. Same reason. > Also, the "#!CAM#" stuff is kinda tacky, IMO. I would suggest either > taking the unsupported controllers out altogether, or else doing something > like this: > > # The following controllers are not supported under CAM, but support may be > # brough back someday. > #controller aic0 at isa? port 0x340 bio irq 11 vector aicintr > #controller uha0 at isa? port "IO_UHA0" bio irq ? drq 5 vector uhaintr > [ ...and so on... ] I seem to remember the controller probe order is significant, so it seems slightly dumb to loose that information - if somebody try to convert a driver, it may not work, even though it would work if probed in the correct order. I know the !CAM stuff is tacky, but so is not indicating why the options are commented out is bad too. Besides, I assume the comments will have a short life, as the drivers are either fixed or removed from the tree. > > @@ -1558,7 +1558,7 @@ > > # ppc ISA-bus parallel port interfaces. > > # > > controller ppbus0 > > -controller vpo0 at ppbus? > > +#!CAM# controller vpo0 at ppbus? > > I believe this one will be brought back shortly. Great! Still, it block LINT from compiling/linking at the moment. (It is unfortunate that the CAM team didn't use it as resource during development, but these things happen - let us now get it fixed :-) Eivind. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-scsi" in the body of the message