From owner-dev-commits-src-main@freebsd.org Mon Mar 1 07:34:54 2021 Return-Path: Delivered-To: dev-commits-src-main@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 7A0C6552376; Mon, 1 Mar 2021 07:34:54 +0000 (UTC) (envelope-from mjguzik@gmail.com) Received: from mail-lj1-x22a.google.com (mail-lj1-x22a.google.com [IPv6:2a00:1450:4864:20::22a]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4DpsV55sfnz3PSq; Mon, 1 Mar 2021 07:34:53 +0000 (UTC) (envelope-from mjguzik@gmail.com) Received: by mail-lj1-x22a.google.com with SMTP id q14so18244727ljp.4; Sun, 28 Feb 2021 23:34:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=0j3oUbPY6lEuDtrnknmgOjzQUowDg7yGzx4s2EVYHBo=; b=KgP6JXrkPXsvO8AFKzaP7G5MnG6j11ZHN2fj+4w+eW9qE+AUT3OvaEPovWKg9Ms8wf Wm686Yi4JB204BujjhhQLE8gM48EBz3z7cD1HZ5aW2Mc9IZFEbweg/lxwgTU0J8nff1J w0Eq21wxLrbKBnWwhiXDFtkEZAqd+rkWfw4hfUwAbnTjWAtLuEobenc1eflEo4AJ/we1 k4jPEJMVIWA5p65oFXN23JxQRccUhNW/LpEFO2Wa512x17RtwGiqswzlFsrD7zFyTAz6 GIX3dyVbHGvBYR50xMHhyMG1KfFKQM2iVUgNQXeNBK+f41gAUdIQFOHX5RVMPQb/iZwv p6Sg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=0j3oUbPY6lEuDtrnknmgOjzQUowDg7yGzx4s2EVYHBo=; b=oCLzM3gDlFiTtSDWv4h8534bXpHitQn5ENj1vl0IO1t/I9RDmHJO9NLlfaTMU7wNzU CGSq/ld0n31uHZLq6o3UM4I0uup6HKMytgHut+Ho2yiPEYYayqOkOds//xoiGbfAcEVK CAqwV3Wzq6bEfgXjKZsZhwXOrWDuHyBOg3daOXFFdI8FKFVQ2rXA6dW63mSota46JcI5 s6ap63xW+BdYGcNj870igVqprTdNnkxMp5H7hP7ROb17kMZF+zwBT8kQcqLhlTB4B/EC T8C0WeUCUX5v+ZG6ptnXe4WpP6wPT3CmPBaVYKPN32GWzNjq5Fte/ks7W4V2rxfVxHWC uiZA== X-Gm-Message-State: AOAM531yro0ubVFe7CXUeNChsCC93Ih3a0gk9WYVL0FvuIddQ2YWc7E5 vaXx/mrQ+sY5/ldM4Kgc0mzacXDFxXSnutJ9Ca8fXkltyms= X-Google-Smtp-Source: ABdhPJxM9ZVRLB7dGk4+9xBc9lTkG2cq51Dig06Lw8gXed2qdIxNNa6eyOAXAlF+hMsVOGllUZhaFpjpK3bmtwSOM90= X-Received: by 2002:a2e:a58d:: with SMTP id m13mr8522064ljp.347.1614584092075; Sun, 28 Feb 2021 23:34:52 -0800 (PST) MIME-Version: 1.0 Received: by 2002:a2e:958d:0:0:0:0:0 with HTTP; Sun, 28 Feb 2021 23:34:51 -0800 (PST) In-Reply-To: <202102232010.11NKAMFt014918@gitrepo.freebsd.org> References: <202102232010.11NKAMFt014918@gitrepo.freebsd.org> From: Mateusz Guzik Date: Mon, 1 Mar 2021 08:34:51 +0100 Message-ID: Subject: Re: git: cf97d2a1dab8 - main - Build lib/msun tests with compiler builtins disabled To: Dimitry Andric Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 4DpsV55sfnz3PSq X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=KgP6JXrk; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (mx1.freebsd.org: domain of mjguzik@gmail.com designates 2a00:1450:4864:20::22a as permitted sender) smtp.mailfrom=mjguzik@gmail.com X-Spamd-Result: default: False [-4.00 / 15.00]; ARC_NA(0.00)[]; RBL_DBL_DONT_QUERY_IPS(0.00)[2a00:1450:4864:20::22a:from]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20161025]; RCVD_TLS_ALL(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; R_SPF_ALLOW(-0.20)[+ip6:2a00:1450:4000::/36:c]; FREEMAIL_FROM(0.00)[gmail.com]; MIME_GOOD(-0.10)[text/plain]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; TO_DN_SOME(0.00)[]; SPAMHAUS_ZRD(0.00)[2a00:1450:4864:20::22a:from:127.0.2.255]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; DKIM_TRACE(0.00)[gmail.com:+]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; RCVD_IN_DNSWL_NONE(0.00)[2a00:1450:4864:20::22a:from]; NEURAL_HAM_SHORT(-1.00)[-1.000]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2a00:1450::/32, country:US]; RCVD_COUNT_TWO(0.00)[2]; MAILMAN_DEST(0.00)[dev-commits-src-all,dev-commits-src-main]; DWL_DNSWL_NONE(0.00)[gmail.com:dkim] X-BeenThere: dev-commits-src-main@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for the main branch of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Mar 2021 07:34:54 -0000 This breaks riscv: ld: error: undefined symbol: fabs >>> referenced by t_acos.c:93 (/usr/src/contrib/netbsd-tests/lib/libm/t_acos.c:93) >>> t_acos.o:(atfu_acos_is_plus_zero_body) >>> referenced by t_acos.c:94 (/usr/src/contrib/netbsd-tests/lib/libm/t_acos.c:94) >>> t_acos.o:(atfu_acos_is_plus_zero_body) >>> did you mean: cabs >>> defined in: /usr/obj/usr/src/riscv.riscv64sf/tmp/usr/lib/libm.so On 2/23/21, Dimitry Andric wrote: > The branch main has been updated by dim: > > URL: > https://cgit.FreeBSD.org/src/commit/?id=cf97d2a1dab8f2cddc4466fe64d37818339c73be > > commit cf97d2a1dab8f2cddc4466fe64d37818339c73be > Author: Dimitry Andric > AuthorDate: 2021-02-23 20:03:32 +0000 > Commit: Dimitry Andric > CommitDate: 2021-02-23 20:10:01 +0000 > > Build lib/msun tests with compiler builtins disabled > > This forces the compiler to emit calls to libm functions, instead of > possibly substituting pre-calculated results at compile time, which > should help to actually test those functions. > > Reviewed by: emaste, arichardson, ngie > Differential Revision: https://reviews.freebsd.org/D28577 > MFC after: 3 days > --- > lib/msun/tests/Makefile | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/lib/msun/tests/Makefile b/lib/msun/tests/Makefile > index d58333271e9b..85a558bb0733 100644 > --- a/lib/msun/tests/Makefile > +++ b/lib/msun/tests/Makefile > @@ -19,6 +19,10 @@ CFLAGS+= -I${TESTSRC:H}/libc/gen > CFLAGS+= -D__HAVE_LONG_DOUBLE > .endif > > +# Avoid builtins, to force the compiler to emit calls to the libm > +# functions, and not calculate any results in advance. > +CFLAGS+= -fno-builtin > + > NETBSD_ATF_TESTS_C= acos_test > NETBSD_ATF_TESTS_C+= asin_test > NETBSD_ATF_TESTS_C+= atan_test > -- Mateusz Guzik