From owner-cvs-src@FreeBSD.ORG  Sun Feb 29 23:17:21 2004
Return-Path: <owner-cvs-src@FreeBSD.ORG>
Delivered-To: cvs-src@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 2EA1F16A4CE; Sun, 29 Feb 2004 23:17:21 -0800 (PST)
Received: from critter.freebsd.dk (critter.freebsd.dk [212.242.86.163])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 5E53343D2F; Sun, 29 Feb 2004 23:17:20 -0800 (PST)
	(envelope-from phk@phk.freebsd.dk)
Received: from critter.freebsd.dk (localhost [127.0.0.1])
	by critter.freebsd.dk (8.12.11/8.12.11) with ESMTP id i217HC1g050035;
	Mon, 1 Mar 2004 08:17:17 +0100 (CET)
	(envelope-from phk@phk.freebsd.dk)
To: Bruce Evans <bde@zeta.org.au>
From: "Poul-Henning Kamp" <phk@phk.freebsd.dk>
In-Reply-To: Your message of "Mon, 01 Mar 2004 18:07:06 +1100."
             <20040301175645.N12828@gamplex.bde.org> 
Date: Mon, 01 Mar 2004 08:17:12 +0100
Message-ID: <50034.1078125432@critter.freebsd.dk>
cc: cvs-src@FreeBSD.org
cc: src-committers@FreeBSD.org
cc: cvs-all@FreeBSD.org
cc: Nate Lawson <nate@root.org>
Subject: Re: cvs commit: src/sys/ddb db_command.c 
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 01 Mar 2004 07:17:21 -0000

In message <20040301175645.N12828@gamplex.bde.org>, Bruce Evans writes:
>On Sun, 29 Feb 2004, Nate Lawson wrote:
>
>> On Sun, 29 Feb 2004, Poul-Henning Kamp wrote:
>> >   FreeBSD src repository
>> >
>> >   Modified files:
>> >     sys/ddb              db_command.c
>> >   Log:
>> >   Give DDB a "watchdog" command which disables all watchdogs.
>> >
>> >   Revision  Changes    Path
>> >   1.53      +21 -0     src/sys/ddb/db_command.c
>>
>> Shouldn't that be hooked into the normal debugger enter sequence?

I don't think so.  At least if it should there should be a sysctl
to set the timeout to be used.

>- no ifdefs to make it go away when watchdogs are not configured.

watchdog infrastructure is not optional, it takes only 823 bytes
in LINT, making it optional would be vastly overkill.

-- 
Poul-Henning Kamp       | UNIX since Zilog Zeus 3.20
phk@FreeBSD.ORG         | TCP/IP since RFC 956
FreeBSD committer       | BSD since 4.3-tahoe    
Never attribute to malice what can adequately be explained by incompetence.