From owner-freebsd-current@FreeBSD.ORG Fri Sep 29 23:21:19 2006 Return-Path: X-Original-To: current@FreeBSD.org Delivered-To: freebsd-current@FreeBSD.ORG Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id CB4DC16A403; Fri, 29 Sep 2006 23:21:19 +0000 (UTC) (envelope-from jmg@hydrogen.funkthat.com) Received: from hydrogen.funkthat.com (gate.funkthat.com [69.17.45.168]) by mx1.FreeBSD.org (Postfix) with ESMTP id E6C1843D4C; Fri, 29 Sep 2006 23:21:16 +0000 (GMT) (envelope-from jmg@hydrogen.funkthat.com) Received: from hydrogen.funkthat.com (q58bmqjvchspmfjz@localhost.funkthat.com [127.0.0.1]) by hydrogen.funkthat.com (8.13.6/8.13.3) with ESMTP id k8TNLGDg037624; Fri, 29 Sep 2006 16:21:16 -0700 (PDT) (envelope-from jmg@hydrogen.funkthat.com) Received: (from jmg@localhost) by hydrogen.funkthat.com (8.13.6/8.13.3/Submit) id k8TNLGqO037623; Fri, 29 Sep 2006 16:21:16 -0700 (PDT) (envelope-from jmg) Date: Fri, 29 Sep 2006 16:21:15 -0700 From: John-Mark Gurney To: Robert Watson Message-ID: <20060929232115.GT80527@funkthat.com> Mail-Followup-To: Robert Watson , Pawel Jakub Dawidek , ru@FreeBSD.org, current@FreeBSD.org References: <20060929141709.E70454@fledge.watson.org> <20060929155526.GA9194@garage.freebsd.pl> <20060929172321.R74256@fledge.watson.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20060929172321.R74256@fledge.watson.org> User-Agent: Mutt/1.4.2.1i X-Operating-System: FreeBSD 5.4-RELEASE-p6 i386 X-PGP-Fingerprint: B7 EC EF F8 AE ED A7 31 96 7A 22 B3 D8 56 36 F4 X-Files: The truth is out there X-URL: http://resnet.uoregon.edu/~gurney_j/ X-Resume: http://resnet.uoregon.edu/~gurney_j/resume.html Cc: ru@FreeBSD.org, Pawel Jakub Dawidek , current@FreeBSD.org Subject: Re: lockf in installworld -- not a good idea X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: John-Mark Gurney List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 29 Sep 2006 23:21:19 -0000 Robert Watson wrote this message on Fri, Sep 29, 2006 at 17:24 +0100: > > On Fri, 29 Sep 2006, Pawel Jakub Dawidek wrote: > > >On Fri, Sep 29, 2006 at 02:20:06PM +0100, Robert Watson wrote: > >>I've noticed an increasing intolerance in our tools for system install > >>and maintenance to locking not being implemented over the past few years. > >>I no longer get working > >>cron on boxes with neither rpc.lockd nor local locking enabled, for > >>example. [...] > > > >If you are refering to my change in which cron(8) started to use > >pidfile(3), then I'm sorry, but you're wrong. > > > >cron(8) from the very beginning was exiting when it had problems with > >creating a pidfile, please check function acquire_daemonlock() in: > > Cron may have been a poor example, I picked it from the top of a list of a > half dozen failed services, many of which used not to fail. Sorry about > that. > > >The way I prefer is to ignore errors other than EEXIST - you can check > >EXAMPLES section in the pidfile(3) manual page for more info. I just > >didn't wanted to change cron(8)'s original behaviour. > > > >I do agree, that this shouldn't be treated as critical error and I can > >change it if you like. > > I think if we get back EOPNOTSUPP from lock attempts in libpidfile, we > should ignore it and hope for the best. In an ideal world, we wouldn't do > this, but in an ideal world we also wouldn't need to. :-) Why not: -L Do not forward fcntl(2) locks over the wire. All locks will be local and not seen by the server and likewise not seen by other NFS clients. This removes the need to run the rpcbind(8) service and the rpc.statd(8) and rpc.lockd(8) servers on the client. Note that this option will only be honored when performing the initial mount, it will be silently ignored if used while updating the mount options. Seems like most of these cases -L makes the most sense... I don't see a reason you'd share var's between machines, and doubt that you'd be installing world to the same tree from two different machines... -- John-Mark Gurney Voice: +1 415 225 5579 "All that I will do, has been done, All that I have, has not."