From owner-freebsd-mobile Mon Mar 12 23:42:20 2001 Delivered-To: freebsd-mobile@freebsd.org Received: from freebsd.dk (freebsd.dk [212.242.42.178]) by hub.freebsd.org (Postfix) with ESMTP id 158F737B719; Mon, 12 Mar 2001 23:42:17 -0800 (PST) (envelope-from sos@freebsd.dk) Received: (from sos@localhost) by freebsd.dk (8.9.3/8.9.1) id IAA63705; Tue, 13 Mar 2001 08:40:58 +0100 (CET) (envelope-from sos) From: Soren Schmidt Message-Id: <200103130740.IAA63705@freebsd.dk> Subject: Re: iomega clik! In-Reply-To: <200103130331.f2D3VPI42148@harmony.village.org> from Warner Losh at "Mar 12, 2001 08:31:25 pm" To: imp@harmony.village.org (Warner Losh) Date: Tue, 13 Mar 2001 08:40:58 +0100 (CET) Cc: sos@FreeBSD.ORG, mobile@FreeBSD.ORG X-Mailer: ELM [version 2.4ME+ PL54 (25)] MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8bit Sender: owner-freebsd-mobile@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.org It seems Warner Losh wrote: > In message <200103121017.LAA45917@freebsd.dk> Soren Schmidt writes: > : OK, here is the "official" patch for the clik, the detach part > : is handled by another patch set I have in the wings, that deals > : with prober detach/attach of devices, but thats for another time.. > : Anyhow I cannot test this, so please let me know if this makes > : the clik work... > > This won't work. The clik! cannot execute afd_prevent_allow(). > That's why I added the iomega_clik to the softc. Thats why I have this in the patch: @@ -423,5 +452,8 @@ int8_t ccb[16] = { ATAPI_PREVENT_ALLOW, 0, 0, 0, lock, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0 }; - return atapi_queue_cmd(fdp->atp, ccb, NULL, 0, 0,30, NULL, NULL); + if (!strncmp(ATA_PARAM(fdp->atp->controller, fdp->atp->unit)->model, + "IOMEGA Clik!", 12)) + return 0; + return atapi_queue_cmd(fdp->atp, ccb, NULL, 0, 0, 30, NULL, NULL); } -Søren To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-mobile" in the body of the message