From owner-svn-src-all@freebsd.org Tue Sep 11 14:49:14 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 8B0E31093168; Tue, 11 Sep 2018 14:49:14 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: from mail-pg1-x52d.google.com (mail-pg1-x52d.google.com [IPv6:2607:f8b0:4864:20::52d]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id EF0CE79B0A; Tue, 11 Sep 2018 14:49:13 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: by mail-pg1-x52d.google.com with SMTP id d1-v6so12392897pgo.3; Tue, 11 Sep 2018 07:49:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=BhvokqwR6EHn6QzxbbYk/HSsl87mvKa3Q87zmpezl1M=; b=nNQQJv5367P1AaTMhiYKiIrSXX0OAQJeWncCr7Wds8auTYpgVZtdZAppojHp+SkHRV 8X97LzfQcD4fe56qFXL7xKESCYsYveYwOJeVa14XqQm72AmeyLoCVGLccLxy+aaj3Dhr Lvu3fSosEGr7TVPMyfgiXa35w4VBSILX+gsO/W/69lU5iAX/CHRDuBg2nmQziZWn5yW8 5LdlsA/paforJqIOzjmNRzcpP9D2LRT9kV7s1+WU7crgVkj0+VqGbVdE9MYcgcFPJXd9 Kw7fONydEMZtXG1Z0xtmKRAD+OI3Bvzd3yUduYcd78OKHg1Y0gfWUaJ73Qo23VozT7E2 Jp1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=BhvokqwR6EHn6QzxbbYk/HSsl87mvKa3Q87zmpezl1M=; b=k01XKedMj7af8LW9GPrKQQyZdtuUe0KczMGAbO3SScGMKorYb1OS2BF8NqoKgcvDIa rjifR2UQqayw24btNwqA6nYjLMcT6MfIftYGyaZUvkSCKBdry4MP07EOwU0N7nDoXXG7 HBdhZoYR8p/Mkymd+IfFNi8vFB4jYALZc39ydNiEWPJxHbIzeRFWapxyYJw6js7LGUPU pHAxnUYZm0Ija3R0aJwvLZ7kIeQntXnWyPk89NTFBdeNaqnIF1630eC3mq/mxMqigGcJ qHq9GwyMLushN1HYFg0c7lyfQzD+8kzvWcExs5KbXGk/eWISwu0Q9wba2sdQW7cSJIBO fPTQ== X-Gm-Message-State: APzg51Bkhfgr5fPoRiE3Xf+SG1JnkiIch7X7fiQxhwulXs+3u1Bn2kLf Fhsd5E8bll1KEZ3mrivcC0r0ME66 X-Google-Smtp-Source: ANB0VdZOmYLZzUi9qnTgC/TYrpgfxmj1P2pTaqW+AKxfEU6559dBQNlk5ZfBJ8F3+ZOyPDDqx3jRZg== X-Received: by 2002:a63:7b4b:: with SMTP id k11-v6mr29286865pgn.64.1536677352860; Tue, 11 Sep 2018 07:49:12 -0700 (PDT) Received: from raichu (toroon0560w-lp130-01-174-88-78-8.dsl.bell.ca. [174.88.78.8]) by smtp.gmail.com with ESMTPSA id t17-v6sm39475622pfm.138.2018.09.11.07.49.11 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 11 Sep 2018 07:49:11 -0700 (PDT) Sender: Mark Johnston Date: Tue, 11 Sep 2018 10:49:06 -0400 From: Mark Johnston To: Alexander Leidinger Cc: Bjoern Zeeb , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r338571 - in head/sys: netinet netinet6 Message-ID: <20180911144906.GA92634@raichu> References: <201809101900.w8AJ0TAQ055228@repo.freebsd.org> <20180911121305.Horde.J3vJzVyD-MnqSCzDlCW7an7@webmail.leidinger.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180911121305.Horde.J3vJzVyD-MnqSCzDlCW7an7@webmail.leidinger.net> User-Agent: Mutt/1.10.1 (2018-07-13) X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 11 Sep 2018 14:49:14 -0000 On Tue, Sep 11, 2018 at 12:13:05PM +0200, Alexander Leidinger wrote: > > Quoting Mark Johnston (from Mon, 10 Sep 2018 > 19:00:29 +0000 (UTC)): > > > Author: markj > > Date: Mon Sep 10 19:00:29 2018 > > New Revision: 338571 > > URL: https://svnweb.freebsd.org/changeset/base/338571 > > > > Log: > > Fix synchronization of LB group access. > > > > Lookups are protected by an epoch section, so the LB group linkage must > > be a CK_LIST rather than a plain LIST. Furthermore, we were not > > deferring LB group frees, so in_pcbremlbgrouphash() could race with > > readers and cause a use-after-free. > > Is this related to PR 230950? > https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=230950 Probably not. SO_REUSEPORT_LB is new and not many applications use it yet; nginx is the sole consumer that I've found. The issues fixed in this commit were found by code inspection.