From owner-svn-src-stable@freebsd.org Thu Dec 29 14:38:34 2016 Return-Path: Delivered-To: svn-src-stable@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id A040DC95E43; Thu, 29 Dec 2016 14:38:34 +0000 (UTC) (envelope-from freebsd-rwg@pdx.rh.CN85.dnsmgr.net) Received: from pdx.rh.CN85.dnsmgr.net (br1.CN84in.dnsmgr.net [69.59.192.140]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 77BAD12F3; Thu, 29 Dec 2016 14:38:34 +0000 (UTC) (envelope-from freebsd-rwg@pdx.rh.CN85.dnsmgr.net) Received: from pdx.rh.CN85.dnsmgr.net (localhost [127.0.0.1]) by pdx.rh.CN85.dnsmgr.net (8.13.3/8.13.3) with ESMTP id uBTEcFsj006549; Thu, 29 Dec 2016 06:38:20 -0800 (PST) (envelope-from freebsd-rwg@pdx.rh.CN85.dnsmgr.net) Received: (from freebsd-rwg@localhost) by pdx.rh.CN85.dnsmgr.net (8.13.3/8.13.3/Submit) id uBTEcARM006548; Thu, 29 Dec 2016 06:38:10 -0800 (PST) (envelope-from freebsd-rwg) From: "Rodney W. Grimes" Message-Id: <201612291438.uBTEcARM006548@pdx.rh.CN85.dnsmgr.net> Subject: Re: svn commit: r310773 - in stable/11/sys: netinet netinet6 In-Reply-To: <201612291132.uBTBWgLM065597@repo.freebsd.org> To: Michael Tuexen Date: Thu, 29 Dec 2016 06:38:10 -0800 (PST) CC: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-11@freebsd.org X-Mailer: ELM [version 2.4ME+ PL121h (25)] MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII X-BeenThere: svn-src-stable@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for all the -stable branches of the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Dec 2016 14:38:34 -0000 > Author: tuexen > Date: Thu Dec 29 11:32:42 2016 > New Revision: 310773 > URL: https://svnweb.freebsd.org/changeset/base/310773 > > Log: > MFC r310590: > > Whitespace changes. > > The toolchain for processing the sources has been updated. No functional > change. What tool chain? It is still broken in at least 1 respect: > /* now use the rest of the mbuf chain for the text */ > while (m_tmp != NULL) { > if ((SCTP_BUF_NEXT(m_tmp) == NULL) && trailer) { > - sctp_hmac_update(hmac_algo, &ctx, mtod(m_tmp, uint8_t *) + m_offset, > + sctp_hmac_update(hmac_algo, &ctx, mtod(m_tmp, uint8_t *)+m_offset, ^^^^^^^^^^^^^^ > SCTP_BUF_LEN(m_tmp) - (trailer + m_offset)); > } else { > - sctp_hmac_update(hmac_algo, &ctx, mtod(m_tmp, uint8_t *) + m_offset, > + sctp_hmac_update(hmac_algo, &ctx, mtod(m_tmp, uint8_t *)+m_offset, ^^^^^^^^^^^ > SCTP_BUF_LEN(m_tmp) - m_offset); > } > ... others errors of this type occur in this patch. I think it would of been better to revert the old patch that messed up some comments before creating this change as now there are other changes intermingled making the 2 changes inter-dependent. Even with this small nit, I applaud the number of style(9) corrections! -- Rod Grimes rgrimes@freebsd.org