From owner-freebsd-ports@FreeBSD.ORG Mon Jun 18 08:12:24 2012 Return-Path: Delivered-To: freebsd-ports@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id D5E6E1065672; Mon, 18 Jun 2012 08:12:24 +0000 (UTC) (envelope-from matthew@FreeBSD.org) Received: from smtp.infracaninophile.co.uk (smtp6.infracaninophile.co.uk [IPv6:2001:8b0:151:1:3cd3:cd67:fafa:3d78]) by mx1.freebsd.org (Postfix) with ESMTP id 5E1D38FC18; Mon, 18 Jun 2012 08:12:24 +0000 (UTC) Received: from seedling.black-earth.co.uk (seedling.black-earth.co.uk [81.187.76.163]) (authenticated bits=0) by smtp.infracaninophile.co.uk (8.14.5/8.14.5) with ESMTP id q5I8CEZP020876 (version=TLSv1/SSLv3 cipher=DHE-RSA-CAMELLIA256-SHA bits=256 verify=NO); Mon, 18 Jun 2012 09:12:15 +0100 (BST) (envelope-from matthew@FreeBSD.org) X-DKIM: OpenDKIM Filter v2.5.2 smtp.infracaninophile.co.uk q5I8CEZP020876 Authentication-Results: smtp.infracaninophile.co.uk/q5I8CEZP020876; dkim=none (no signature); dkim-adsp=none Message-ID: <4FDEE2DE.2010408@FreeBSD.org> Date: Mon, 18 Jun 2012 09:12:14 +0100 From: Matthew Seaman User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:13.0) Gecko/20120614 Thunderbird/13.0.1 MIME-Version: 1.0 To: Mel Flynn References: <4FD8AFEC.6070605@FreeBSD.org> <4FDC9488.2010509@FreeBSD.org> <20120616145341.GK98264@ithaqua.etoilebsd.net> <4FDCA0FC.3050407@acsalaska.net> <20120616151125.GL98264@ithaqua.etoilebsd.net> <4FDE2195.7090901@acsalaska.net> <20120617195109.GA1274@ithaqua.etoilebsd.net> <4FDE39DF.4090208@acsalaska.net> In-Reply-To: <4FDE39DF.4090208@acsalaska.net> X-Enigmail-Version: 1.4.2 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enigACAFEB5F8F138863E061C8DB" X-Virus-Scanned: clamav-milter 0.97.4 at lucid-nonsense.infracaninophile.co.uk X-Virus-Status: Clean X-Spam-Status: No, score=-2.8 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.3.2 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on lucid-nonsense.infracaninophile.co.uk Cc: Chris Rees , Baptiste Daroussin , freebsd-ports Subject: Re: [CFT] UNIQUENAME patches X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Jun 2012 08:12:25 -0000 This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigACAFEB5F8F138863E061C8DB Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On 17/06/2012 21:11, Mel Flynn wrote: >>> >> I really don't see what the problem is with setting uniquename to:= >>> >> ${PORTORIGIN:S,/,__,}+${CHILDPORTNAME} >>> >> or: >>> >> databases/mysql55+server >>> >> databases/mysql55+client >>> >> etc. >> > And so you want to forbid + as a character for PORTNAME? So you woul= d need to >> > fix all the ports having a + in the name. > No. Ports all have a version starting with a minus sign, yet we have > ports with a minus sign in it. This is the same principle. The plus or > whatever char you pick, should be the first one from the right side > after the version part. What's in between the plus and the start of > version is subpackage/childport name. Deciding what character or characters to use to distinguish the sub-port part of the package name from the rest is a particularly bikeshedable point. Virtually any of the punctuation on the keyboard could be used, and it really won't make much difference in the end what gets chosen. Personally I feel it should be the sole choice of the people that do the work to implement sub-ports. On the point of how UNIQUENAME should be defined, your arguments have some merit, but I'm not convinced. On balance, after considering such points I preferred what I came up with (but then I would say that, wouldn't I?) Cheers, Matthew --=20 Dr Matthew J Seaman MA, D.Phil. PGP: http://www.infracaninophile.co.uk/pgpkey --------------enigACAFEB5F8F138863E061C8DB Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0.16 (Darwin) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAk/e4t4ACgkQ8Mjk52CukIxp+wCfd7jnyzLvX2Lkq01+CGIX/cUk +WAAn0kK1iKq8Pbm8UvTYASbdgupmKFo =v/5M -----END PGP SIGNATURE----- --------------enigACAFEB5F8F138863E061C8DB--