Date: Tue, 26 Oct 2004 18:40:29 +0200 From: "Poul-Henning Kamp" <phk@phk.freebsd.dk> To: John Baldwin <jhb@FreeBSD.org> Cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern vfs_mount.c Message-ID: <45811.1098808829@critter.freebsd.dk> In-Reply-To: Your message of "Tue, 26 Oct 2004 12:19:03 EDT." <200410261219.03262.jhb@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
In message <200410261219.03262.jhb@FreeBSD.org>, John Baldwin writes: >On Saturday 23 October 2004 04:21 pm, Poul-Henning Kamp wrote: >> phk 2004-10-23 20:21:05 UTC >> >> FreeBSD src repository >> >> Modified files: >> sys/kern vfs_mount.c >> Log: >> Drop Giant around the call to g_waitidle(). >> This is necessary to allow any geom events which need it to pick up >> Giant. > >tsleep() already automatically drops Giant for you, so this is not required >for geom events to run. Duh! I was wondering why it hadn't deadlocked... -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?45811.1098808829>