From owner-cvs-all@FreeBSD.ORG Sun Oct 15 05:10:48 2006 Return-Path: X-Original-To: cvs-all@FreeBSD.org Delivered-To: cvs-all@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1D4D716A403; Sun, 15 Oct 2006 05:10:48 +0000 (UTC) (envelope-from kris@obsecurity.org) Received: from elvis.mu.org (elvis.mu.org [192.203.228.196]) by mx1.FreeBSD.org (Postfix) with ESMTP id C363043D49; Sun, 15 Oct 2006 05:10:47 +0000 (GMT) (envelope-from kris@obsecurity.org) Received: from obsecurity.dyndns.org (elvis.mu.org [192.203.228.196]) by elvis.mu.org (Postfix) with ESMTP id 9F1E61A3C19; Sat, 14 Oct 2006 22:10:45 -0700 (PDT) Received: by obsecurity.dyndns.org (Postfix, from userid 1000) id DDFDF514DF; Sun, 15 Oct 2006 01:10:44 -0400 (EDT) Date: Sun, 15 Oct 2006 01:10:44 -0400 From: Kris Kennaway To: Bruce Evans Message-ID: <20061015051044.GA42764@xor.obsecurity.org> References: <200610140725.k9E7PC37008454@repoman.freebsd.org> <20061014231502.GA38708@rink.nu> <20061015105809.M59123@delplex.bde.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="1yeeQ81UyVL57Vl7" Content-Disposition: inline In-Reply-To: <20061015105809.M59123@delplex.bde.org> User-Agent: Mutt/1.4.2.2i Cc: cvs-all@FreeBSD.org, cvs-src@FreeBSD.org, Rink Springer , Bruce Evans , src-committers@FreeBSD.org Subject: Re: cvs commit: src/sys/nfsclient nfs_vnops.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 15 Oct 2006 05:10:48 -0000 --1yeeQ81UyVL57Vl7 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Oct 15, 2006 at 12:37:28PM +1000, Bruce Evans wrote: > On Sun, 15 Oct 2006, Rink Springer wrote: >=20 > >On Sat, Oct 14, 2006 at 07:25:12AM +0000, Bruce Evans wrote: > >> Log: > >> Don't do null Setattr RPCs for VA_MARK_ATIME. When we added the > >>... > >> This is the smallest and easiest to fix of several bugs that have > >> increased the number of RPCs for kernel builds on nfs by more than > >> 100% since 2004-11-05. The real-time increase depends on network > >>... >=20 > >The code in RELENG_6 looks as if it would benefit from this change as > >well. Do you have a MFC planned in the nearby future? >=20 > Maybe after the larger performance bugs are fixed. See a thread in > freebsd-fs. >=20 > It would also be good to reduce nfs RPCs generally and there seems to > be a lot more scope to do this for Access ones, at least by automatically > configuring cases when a large timeout is safe. >=20 > -current and RELENG_6 still have a bogus default of 2 for nfs_access_cache > in /etc/defaults/rc.conf, and rc.conf(5) still confusingly claims that > setting this to a value of 2-10 seconds will substantially reduce > network traffic. In fact the default is 60 and smaller nonzero settings > substantially increase network traffic; a setting of 2 is normally > made by the rc system, and settings of 3-10 only reduce network traffic > not so substantially by moving back towards the system default. Settings > of 2-10 substantially increase network traffic relative to the system > default. > ISTR a discussion of fixing this in rc.conf, but nothing seems to have be= en > committed. The setting is confusing in the kernel too: ---------------------------- revision 1.285 date: 2006/05/24 00:06:14; author: kris; state: Exp; lines: +1 -1 Increase the nfs access cache timeout from 2 to 60. The latter is a more appropriate value and is also the default set by the kernel. I could not find a justification of why rc.conf began overriding it back in 1998. This dramatically cuts NFS traffic on e.g. a busy system with NFS root. Reviewed by: mohans MFC After: 2 weeks ---------------------------- Kris --1yeeQ81UyVL57Vl7 Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.5 (FreeBSD) iD8DBQFFMcLUWry0BWjoQKURAjizAKDajGIeBFxIJWKGq1JYHKzt6l/EJwCgzFzw LCBkfQLvyoK3D0XBTjPjfg8= =aWP4 -----END PGP SIGNATURE----- --1yeeQ81UyVL57Vl7--