From owner-freebsd-current Thu Mar 20 15:50:51 2003 Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id BA77637B401 for ; Thu, 20 Mar 2003 15:50:50 -0800 (PST) Received: from rootlabs.com (root.org [67.118.192.226]) by mx1.FreeBSD.org (Postfix) with SMTP id 4402743FBD for ; Thu, 20 Mar 2003 15:50:47 -0800 (PST) (envelope-from nate@rootlabs.com) Received: (qmail 14588 invoked by uid 1000); 20 Mar 2003 23:50:47 -0000 Date: Thu, 20 Mar 2003 15:50:47 -0800 (PST) From: Nate Lawson To: Steve Kargl Cc: current@FreeBSD.ORG, wpaul@FreeBSD.ORG Subject: Re: Updated if_* attach/detach patches In-Reply-To: <20030320234202.GA70664@troutmask.apl.washington.edu> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Thu, 20 Mar 2003, Steve Kargl wrote: > On Wed, Mar 19, 2003 at 10:37:43AM -0800, Nate Lawson wrote: > > I have updated my patches for: > > dc pcn rl sf sis sk ste ti tl vr wb xl > > They have been compile tested but I only have an rl card so I'd appreciate > > feedback. > > > > - xl: add missed error setting in I/O, memory mapping cases > > - xl: add missing bzero of softc > > - xl: remove multi-level goto on attach failure > > I've tested the xl diff, but only limited internet traffic > (i.e., cvsup, browsing, ssh). If high volume traffic is > needed to testing, I'm not set up to do that. > > I haven't seen in problems. No, the attach/detach routines are only called at boot and shutdown or if you compile it as a module, load/unload. In fact, for people who would like info on how to test it, this would be helpful (replacing the name with your module of course): #!/bin/sh kldload if_xl kldunload if_xl sleep .2 exec $0 Crashing or growing memory use might indicate problems. -Nate To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message