From owner-p4-projects@FreeBSD.ORG  Wed Jan  9 04:24:18 2008
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 2AE1716A421; Wed,  9 Jan 2008 04:24:18 +0000 (UTC)
Delivered-To: perforce@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id AE7D416A41A
	for <perforce@freebsd.org>; Wed,  9 Jan 2008 04:24:17 +0000 (UTC)
	(envelope-from jb@freebsd.org)
Received: from repoman.freebsd.org (repoman.freebsd.org
	[IPv6:2001:4f8:fff6::29])
	by mx1.freebsd.org (Postfix) with ESMTP id 903E313C448
	for <perforce@freebsd.org>; Wed,  9 Jan 2008 04:24:17 +0000 (UTC)
	(envelope-from jb@freebsd.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id m094OHUs017286
	for <perforce@freebsd.org>; Wed, 9 Jan 2008 04:24:17 GMT
	(envelope-from jb@freebsd.org)
Received: (from perforce@localhost)
	by repoman.freebsd.org (8.14.1/8.14.1/Submit) id m094OH7V017283
	for perforce@freebsd.org; Wed, 9 Jan 2008 04:24:17 GMT
	(envelope-from jb@freebsd.org)
Date: Wed, 9 Jan 2008 04:24:17 GMT
Message-Id: <200801090424.m094OH7V017283@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: perforce set sender to
	jb@freebsd.org using -f
From: John Birrell <jb@FreeBSD.org>
To: Perforce Change Reviews <perforce@freebsd.org>
Cc: 
Subject: PERFORCE change 132847 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 09 Jan 2008 04:24:18 -0000

http://perforce.freebsd.org/chv.cgi?CH=132847

Change 132847 by jb@jb_freebsd1 on 2008/01/09 04:23:24

	Return types are a wonderful thing. Provided you actually code them. Oops.
	
	A few debug changes.

Affected files ...

.. //depot/projects/dtrace/src/contrib/opensolaris/tools/ctf/cvt/dwarf.c#13 edit

Differences ...

==== //depot/projects/dtrace/src/contrib/opensolaris/tools/ctf/cvt/dwarf.c#13 (text) ====

@@ -357,8 +357,9 @@
 	*valp = 0;
 	if (dwarf_attrval_signed(die, name, valp, &dw->dw_err) != DWARF_E_NONE) {
 		if (req) 
-			terminate("die %llu: failed to get unsigned: %s\n",
+			terminate("die %llu: failed to get signed: %s\n",
 			    die_off(dw, die), dwarf_errmsg(&dw->dw_err));
+		return (0);
 	}
 
 	return (1);
@@ -373,6 +374,7 @@
 		if (req) 
 			terminate("die %llu: failed to get unsigned: %s\n",
 			    die_off(dw, die), dwarf_errmsg(&dw->dw_err));
+		return (0);
 	}
 
 	return (1);
@@ -387,6 +389,7 @@
 		if (req) 
 			terminate("die %llu: failed to get flag: %s\n",
 			    die_off(dw, die), dwarf_errmsg(&dw->dw_err));
+		return (0);
 	}
 
 	return (1);
@@ -404,6 +407,7 @@
 			    die_off(dw, die), dwarf_errmsg(&dw->dw_err));
 		else
 			*strp = NULL;
+		return (0);
 	} else
 		*strp = xstrdup(str);
 
@@ -658,7 +662,7 @@
 	Dwarf_Unsigned uval;
 	Dwarf_Die dim;
 
-	debug(3, "die %llu: creating array\n", off);
+	debug(3, "die %llu <%llx>: creating array\n", off, off);
 
 	if ((dim = die_child(dw, arr)) == NULL ||
 	    die_tag(dw, dim) != DW_TAG_subrange_type)
@@ -689,7 +693,7 @@
 		tdp->t_flags |= flags;
 	}
 
-	debug(3, "die %llu: array nelems %u size %u\n", off,
+	debug(3, "die %llu <%llx>: array nelems %u size %u\n", off, off,
 	    tdp->t_ardef->ad_nelems, tdp->t_size);
 }
 
@@ -1082,10 +1086,11 @@
 
 	for (ml = tdp->t_members; ml != NULL; ml = ml->ml_next) {
 		if (ml->ml_size == 0) {
-			fprintf(stderr, "%s %d: failed to size member \"%s\" "
-			    "of type %s (%d)\n", typename, tdp->t_id,
+			fprintf(stderr, "%s %d <%x>: failed to size member \"%s\" "
+			    "of type %s (%d <%x>)\n", typename, tdp->t_id,
+			    tdp->t_id,
 			    ml->ml_name, tdesc_name(ml->ml_type),
-			    ml->ml_type->t_id);
+			    ml->ml_type->t_id, ml->ml_type->t_id);
 		}
 	}