From owner-freebsd-bugs  Sat Jan 13 09:17:01 1996
Return-Path: owner-bugs
Received: (from root@localhost)
          by freefall.freebsd.org (8.7.3/8.7.3) id JAA03624
          for bugs-outgoing; Sat, 13 Jan 1996 09:17:01 -0800 (PST)
Received: from unlisys.unlisys.NET (unlisys.unlisys.net [194.64.15.1])
          by freefall.freebsd.org (8.7.3/8.7.3) with SMTP id JAA03613
          for <bugs@FreeBSD.org>; Sat, 13 Jan 1996 09:16:55 -0800 (PST)
Received: by unlisys.unlisys.NET from desert.snafu.de with smtp
	  (Smail3.1.28.1 [@@])  id m0tb9Zk-000Zx0C; Sat, 13 Jan 96 18:17 MET
Received: by desert.snafu.de (Smail3.1.28.1 #9)
	id m0tbATB-0005sVC; Sat, 13 Jan 96 18:14 WET
Received: (from root@localhost) by mscu.snafu.de (8.6.12/8.6.12) id RAA00371 for bugs@FreeBSD.org; Fri, 12 Jan 1996 17:07:05 +0100
From: Matthias Schündehütte <root@mscu.snafu.de>
Message-Id: <199601121607.RAA00371@mscu.snafu.de>
Subject: <sys/mount.h>
To: bugs@FreeBSD.org
Date: Fri, 12 Jan 1996 17:07:05 +0100 (MET)
X-Mailer: ELM [version 2.4 PL24 ME8a]
Content-Type: text
Sender: owner-bugs@FreeBSD.org
Precedence: bulk

Hi there,

while compiling the last version of 'cnews' I got the following error:

> [...]
> cc  -O2  -I../include -c dostatfs.c
> In file included from /usr/include/sys/mount.h:41,
>                  from dostatfs.c:17:
> /usr/include/sys/ucred.h:47: `NGROUPS' undeclared here (not in a function)

it's the following version of cnews:

-rw-r--r-- root/wheel       674596 Nov 30 21:23 1995 cnews.tar.Z

I just installed FreeBSD 2.1.0 from the WalnutCreek CD-ROM. I previously
compiled just that version of cnews under 2.0.5 without such problems.

I looked at /usr/include/sys/ucred.h and found the following lines:

> [...]
> 43 struct ucred {
> 44         u_short cr_ref;                 /* reference count */
> 45         uid_t   cr_uid;                 /* effective user id */
> 46         short   cr_ngroups;             /* number of groups */
> 47         gid_t   cr_groups[NGROUPS];     /* groups */
> 48 };                       =========

and ideed, NGROUPS isn't defined, neither in ucred.h nor in mount.h. It IS
defined in <sys/syslimits.h> via <sys/params.h>.

So here's my question: Where's the bug?

Is it in <sys/mount.h> where <sys/params.h> isn't included ?
Is it in <sys/ucred.h> where <sys/params.h> isn't included ?
Is it in $CNEWSROOT/util/dostatfs.c  where <sys/params.h> isn't included ?

I don't think that cnews is buggy because it compiled under FreeBSD 2.0.5. And
I don't want to edit "/usr/include"-files - they really should be read-only.

TIA - Matthias Schuendehuette (matthias@mscu.snafu.de)

--------------------------------------------------------------------------------
Matthias Schündehütte	matthias@mscu.snafu.de
Solmsstraße 44
D-10961 Berlin
GERMANY
--------------------------------------------------------------------------------