From owner-svn-src-head@freebsd.org Fri Aug 25 18:58:33 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id B6914DDF1FD; Fri, 25 Aug 2017 18:58:33 +0000 (UTC) (envelope-from dim@FreeBSD.org) Received: from tensor.andric.com (tensor.andric.com [87.251.56.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "tensor.andric.com", Issuer "COMODO RSA Domain Validation Secure Server CA" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 7990F6C976; Fri, 25 Aug 2017 18:58:33 +0000 (UTC) (envelope-from dim@FreeBSD.org) Received: from [IPv6:2001:470:7a58::d91a:7f20:7200:12cd] (unknown [IPv6:2001:470:7a58:0:d91a:7f20:7200:12cd]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by tensor.andric.com (Postfix) with ESMTPSA id 6D21630D4F; Fri, 25 Aug 2017 20:58:31 +0200 (CEST) From: Dimitry Andric Message-Id: <00CB256A-DC74-4D65-B21E-16524A21AFF3@FreeBSD.org> Content-Type: multipart/signed; boundary="Apple-Mail=_D5074571-40BC-44C3-9F2A-EE3ECC517CAE"; protocol="application/pgp-signature"; micalg=pgp-sha1 Mime-Version: 1.0 (Mac OS X Mail 10.3 \(3273\)) Subject: Re: svn commit: r322824 - in head: lib/clang share/mk usr.bin/clang Date: Fri, 25 Aug 2017 20:58:30 +0200 In-Reply-To: Cc: John Baldwin , src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org To: Ryan Libby References: <201708232330.v7NNUPpV052276@repo.freebsd.org> X-Mailer: Apple Mail (2.3273) X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Aug 2017 18:58:33 -0000 --Apple-Mail=_D5074571-40BC-44C3-9F2A-EE3ECC517CAE Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=us-ascii On 25 Aug 2017, at 20:07, Ryan Libby wrote: > > On Wed, Aug 23, 2017 at 4:30 PM, John Baldwin wrote: >> Author: jhb >> Date: Wed Aug 23 23:30:25 2017 >> New Revision: 322824 >> URL: https://svnweb.freebsd.org/changeset/base/322824 >> >> Log: >> Improve the coverage of debug symbols for MK_DEBUG_FILES. >> >> - Include debug symbols in static libraries. This permits binaries >> to include debug symbols for functions obtained from static libraries. >> - Permit the C/C++ compiler flags added for MK_DEBUG_FILES to be >> overridden by setting DEBUG_FILES_CFLAGS. Use this to limit the debug >> information for llvm libraries and binaries. >> >> Reviewed by: emaste >> Sponsored by: DARPA / AFRL >> Differential Revision: https://reviews.freebsd.org/D12025 >> >> Added: >> head/lib/clang/Makefile.inc (contents, props changed) >> Modified: >> head/share/mk/bsd.lib.mk >> head/share/mk/bsd.prog.mk >> head/share/mk/bsd.sys.mk >> head/usr.bin/clang/Makefile.inc > > This causes llvm to emit hundreds of new warnings [1] for > "DWARF2 only supports one section per compilation unit" > > Are these expected? Are they a concern? Should we silence them? > Is this an upstream llvm bug [2]? Last time this came up, I put up an upstream review to fix the warning, since it is nonsensical to warn about a non-code section. I've pinged the review again, but now I'm inclined to just commit it. :) -Dimitry --Apple-Mail=_D5074571-40BC-44C3-9F2A-EE3ECC517CAE Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.1 iF0EARECAB0WIQR6tGLSzjX8bUI5T82wXqMKLiCWowUCWaBzVgAKCRCwXqMKLiCW o5XIAJwNbU4Q8dtOpUErFUlLpdnIjAtfyACgzdsrifvRBcymncSXM+se+rDvwc8= =8ugc -----END PGP SIGNATURE----- --Apple-Mail=_D5074571-40BC-44C3-9F2A-EE3ECC517CAE--