Date: Fri, 25 Aug 2017 20:58:30 +0200 From: Dimitry Andric <dim@FreeBSD.org> To: Ryan Libby <rlibby@gmail.com> Cc: John Baldwin <jhb@freebsd.org>, src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r322824 - in head: lib/clang share/mk usr.bin/clang Message-ID: <00CB256A-DC74-4D65-B21E-16524A21AFF3@FreeBSD.org> In-Reply-To: <CAHgpiFwzK5FyB6GDSXdGReO=wAQOAFDxqtQRNZWSR4WHz4ULEA@mail.gmail.com> References: <201708232330.v7NNUPpV052276@repo.freebsd.org> <CAHgpiFwzK5FyB6GDSXdGReO=wAQOAFDxqtQRNZWSR4WHz4ULEA@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--Apple-Mail=_D5074571-40BC-44C3-9F2A-EE3ECC517CAE Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=us-ascii On 25 Aug 2017, at 20:07, Ryan Libby <rlibby@gmail.com> wrote: > > On Wed, Aug 23, 2017 at 4:30 PM, John Baldwin <jhb@freebsd.org> wrote: >> Author: jhb >> Date: Wed Aug 23 23:30:25 2017 >> New Revision: 322824 >> URL: https://svnweb.freebsd.org/changeset/base/322824 >> >> Log: >> Improve the coverage of debug symbols for MK_DEBUG_FILES. >> >> - Include debug symbols in static libraries. This permits binaries >> to include debug symbols for functions obtained from static libraries. >> - Permit the C/C++ compiler flags added for MK_DEBUG_FILES to be >> overridden by setting DEBUG_FILES_CFLAGS. Use this to limit the debug >> information for llvm libraries and binaries. >> >> Reviewed by: emaste >> Sponsored by: DARPA / AFRL >> Differential Revision: https://reviews.freebsd.org/D12025 >> >> Added: >> head/lib/clang/Makefile.inc (contents, props changed) >> Modified: >> head/share/mk/bsd.lib.mk >> head/share/mk/bsd.prog.mk >> head/share/mk/bsd.sys.mk >> head/usr.bin/clang/Makefile.inc > > This causes llvm to emit hundreds of new warnings [1] for > "DWARF2 only supports one section per compilation unit" > > Are these expected? Are they a concern? Should we silence them? > Is this an upstream llvm bug [2]? Last time this came up, I put up an upstream review to fix the warning, since it is nonsensical to warn about a non-code section. I've pinged the review again, but now I'm inclined to just commit it. :) -Dimitry --Apple-Mail=_D5074571-40BC-44C3-9F2A-EE3ECC517CAE Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.1 iF0EARECAB0WIQR6tGLSzjX8bUI5T82wXqMKLiCWowUCWaBzVgAKCRCwXqMKLiCW o5XIAJwNbU4Q8dtOpUErFUlLpdnIjAtfyACgzdsrifvRBcymncSXM+se+rDvwc8= =8ugc -----END PGP SIGNATURE----- --Apple-Mail=_D5074571-40BC-44C3-9F2A-EE3ECC517CAE--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?00CB256A-DC74-4D65-B21E-16524A21AFF3>