From owner-freebsd-gnome@FreeBSD.ORG Tue Feb 21 03:12:30 2006 Return-Path: X-Original-To: gnome@freebsd.org Delivered-To: freebsd-gnome@FreeBSD.ORG Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id CA1B116A420 for ; Tue, 21 Feb 2006 03:12:30 +0000 (GMT) (envelope-from bland@FreeBSD.org) Received: from smtp4.jp.viruscheck.net (smtp4.jp.viruscheck.net [154.33.69.55]) by mx1.FreeBSD.org (Postfix) with ESMTP id 63F2143D45 for ; Tue, 21 Feb 2006 03:12:30 +0000 (GMT) (envelope-from bland@FreeBSD.org) Received: from scan1.jp.viruscheck.net ([154.33.69.36] helo=mail2.jp.viruscheck.net) by smtp4.jp.viruscheck.net with esmtp (Exim 3.36 #1) id 1FBNwu-0005p0-00; Tue, 21 Feb 2006 12:12:24 +0900 Received: from [60.42.120.178] (helo=noc.orchid.orchidtechnology.com) by mail2.jp.viruscheck.net with esmtp (Exim 3.36 #3) id 1FBNwt-0003Iy-00; Tue, 21 Feb 2006 12:12:23 +0900 Received: from [89.60.10.11] (horse.orchid.orchidtechnology.com [89.60.10.11]) by noc.orchid.orchidtechnology.com (8.13.4/8.13.4) with ESMTP id k1L3CM0S062230; Tue, 21 Feb 2006 12:12:22 +0900 (JST) (envelope-from bland@FreeBSD.org) Message-ID: <43FA8516.5020404@FreeBSD.org> Date: Tue, 21 Feb 2006 12:12:22 +0900 From: Alexander Nedotsukov User-Agent: Thunderbird 1.5 (Windows/20051201) MIME-Version: 1.0 To: Joe Marcus Clarke References: <1140487656.847.6.camel@synergy.odyssey.homeunix.org> <43FA7D9F.5090108@FreeBSD.org> <1140490429.65763.3.camel@shumai.marcuscom.com> In-Reply-To: <1140490429.65763.3.camel@shumai.marcuscom.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: gnome@FreeBSD.org Subject: Re: Eog Crash while opening jpeg-images with EXIF data X-BeenThere: freebsd-gnome@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: GNOME for FreeBSD -- porting and maintaining List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Feb 2006 03:12:30 -0000 Joe Marcus Clarke wrote: > On Tue, 2006-02-21 at 11:40 +0900, Alexander Nedotsukov wrote: > >> Pascal, >> Cast it to (char*) instead. And this is not the only place in that file. >> You have to patch other memcpy()s too. >> > > I think guchar * would be more apt, no? > Well, technically there will be no difference at all. But aesthetically... could be. I preferred plain C char* in hope that it make clear to all that all we need is a byte pointer while guchar* needs a bit more knowledge from accident code reader (let's say s/he must be sure that guchar is not stands for GNU Unicode char which may be more that one byte in size) Nits... :-) > Joe > > >> All the best, >> Alexander. >> Pascal Hofstee wrote: >> >>> i am noticing a consistent eog crash when opening jpeg images with EXIF >>> data (using MC-gnome, eog-2.13.91) on FreeBSD/amd64 7.0-CURRENT >>> >>> The line that causes the crash is libeog/eog-metadata-reader.c:231 >>> >>> memcpy ((void*) ((int)(priv->exif_chunk) + priv->bytes_read), >>> (void*)&buf[i], priv->size); >>> >>> I am about 99% sure the (int) typecast on priv->exit_chunk is truncating >>> the 64-bit pointer into 32-bits causing the application to segfault as a >>> result. I am not 100% on how to properly fix this. >>> >>> If any of you could have a look at this, that would be appreciated. >>> >>> >>> >> _______________________________________________ >> freebsd-gnome@freebsd.org mailing list >> http://lists.freebsd.org/mailman/listinfo/freebsd-gnome >> To unsubscribe, send any mail to "freebsd-gnome-unsubscribe@freebsd.org" >> >>