Date: Sat, 18 Feb 2012 10:14:48 +0000 From: Matthew Seaman <matthew@FreeBSD.org> To: freebsd-ports@FreeBSD.org Cc: marcus@FreeBSD.org Subject: Re: Library numbers in LIB_DEPENDS considered harmful (Re: recent portrevision bump for libvpx) Message-ID: <4F3F7A18.8000609@FreeBSD.org> In-Reply-To: <4F3EEA43.3070808@FreeBSD.org> References: <4F3E289D.9050605@FreeBSD.org> <4F3E2CED.90601@FreeBSD.org> <4F3E3537.9040105@FreeBSD.org> <1329478316415-5492205.post@n5.nabble.com> <4F3E5D41.9050503@aldan.algebra.com> <CAGsORuBjScOG3V1BykyELtqQhvzk-mKELoVrdUEfOk3Zh4X56w@mail.gmail.com> <4F3EBF4F.6010401@aldan.algebra.com> <CAGsORuDeENz7fWe7pg0=udfcSP-nxN_q8=0agD40gO9fwGCZPA@mail.gmail.com> <4F3EE5A1.80407@aldan.algebra.com> <4F3EEA43.3070808@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 2440 and 3156)
--------------enigDDAFDBE41F12AA75B4520106
Content-Type: multipart/mixed; boundary="------------090604060906000608040905"
This is a multi-part message in MIME format.
--------------090604060906000608040905
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: quoted-printable
On 18/02/2012 00:01, Doug Barton wrote:
> On 02/17/2012 15:41, Mikhail T. wrote:
>> If, in fact, the current port does not care, which version of libfoo i=
s
>> uses -- and most software does not -- then declaring an explicit V is
>> wrong: it /gratuitously/ tightens the build-time requirements. Unless =
a
>> particular version is, indeed, required, the above line should read si=
mply:
>>
>> LIB_DEPENDS=3D foo:${PORTSDIR}/cat/libfoo
>=20
> Big +1. Same goes for how some of the build/run deps are specified. Thi=
s
> has definitely become a case of "If you give someone a knob, it's
> overwhelmingly likely that they will twist it."
How about the attached?
Cheers,
Matthew
--=20
Dr Matthew J Seaman MA, D.Phil.
PGP: http://www.infracaninophile.co.uk/pgpkey
--------------090604060906000608040905
Content-Type: text/plain; x-mac-type="0"; x-mac-creator="0";
name="portlint.diff"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: attachment;
filename="portlint.diff"
Index: src/portlint.pl
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
RCS file: /home/ncvs/ports/ports-mgmt/portlint/src/portlint.pl,v
retrieving revision 1.125
diff -u -u -r1.125 portlint.pl
--- src/portlint.pl 27 Dec 2011 01:26:34 -0000 1.125
+++ src/portlint.pl 18 Feb 2012 10:08:27 -0000
@@ -1330,6 +1330,13 @@
"found in \${PORTSDIR}/Mk/bsd.apache.mk.");
}
=20
+ # Check for over-specific shared library dependencies
+ if ( $j eq 'LIB_DEPENDS' && $m{'dep'} =3D~ m/(\.\d+$)/ ) {
+ &perror("WARN", $file, -1, "$j don't specify the " .
+ "ABI version number $1 in $m{dep} unless it is " .
+ "really necessary.");
+ }
+
# check port dir existence
$k =3D $m{'dir'};
$k =3D~ s/\${PORTSDIR}/$ENV{'PORTSDIR'}/;
--------------090604060906000608040905--
--------------enigDDAFDBE41F12AA75B4520106
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"
-----BEGIN PGP SIGNATURE-----
Version: GnuPG/MacGPG2 v2.0.16 (Darwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
iEYEARECAAYFAk8/eiAACgkQ8Mjk52CukIzXxQCeK+osrCC+BTzpRIxyfsHljZDK
T6sAn2yzZG2wUK1ipayBEvtCUYS8dgCh
=yHU4
-----END PGP SIGNATURE-----
--------------enigDDAFDBE41F12AA75B4520106--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4F3F7A18.8000609>