From owner-freebsd-ports@freebsd.org Mon May 23 03:56:42 2016 Return-Path: Delivered-To: freebsd-ports@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id F3947B445A6 for ; Mon, 23 May 2016 03:56:42 +0000 (UTC) (envelope-from ganbold@gmail.com) Received: from mail-oi0-x22c.google.com (mail-oi0-x22c.google.com [IPv6:2607:f8b0:4003:c06::22c]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id B955E1B91 for ; Mon, 23 May 2016 03:56:42 +0000 (UTC) (envelope-from ganbold@gmail.com) Received: by mail-oi0-x22c.google.com with SMTP id j1so21699212oih.3 for ; Sun, 22 May 2016 20:56:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to; bh=exbBjYxD5sZ+8diaNKsYy+NVncJCofefyv01KH1uwGg=; b=iCtbfY6h+JJ6VHaIiPPcOfUKsN9BwqeJ7NkwSOAt7iifDoBa/APs71JE+/h+1uifsb koUspTcxSlUbq7Yl8/2J/39hbWz0duXsFyvrEdfTd8hrDBuWs6gBYHLQHFFgloBNwzev T/dH0dC7JbDqXDtnWXJEYO8y6sQybt99dJobbLi5iVXjXlYjW5bRETUQlFAKiS/jEP6G 9BEHu19Bk0QKP4M12wvE8iaNMJuxV+4623P5KtSbEduFYtWRYDupd49GGuiqw0tvq3Mh bfgFKdJctFeig+A94tXCWigSxnUHyA5by7EBzkiT3kKr6TS5Hhf4jv1LklQmmZAfnNaU 7WDA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to; bh=exbBjYxD5sZ+8diaNKsYy+NVncJCofefyv01KH1uwGg=; b=MBXCSzV4tDYUOQxv2iusLF97Sl5AToPKx3vsx6dE7mlwVx32VTPN5REPIJ1/EjgerV bScBGrlkkk8xUPbmQJslNcABJOwgKdB4SjNaqxMO21iEcuKKNgb8KxfbpjxJ1L0MBmGq rVPdNbUvseloxnkfBjl8VPytMySW3pBI8INxDOcyDgj3piNzO5ZoubYmK6CCIdxOWttQ rm1ANLkpBQASqFXvPXGechfkwfGVruhgdJH9QTA89zcJRVJKinLDnhJ3tWMtzglBTZXq aDU6hONGLopNxZDBICM0FiLC3L4ZaqoANf/A/+dtXPxgVR26YZibohmIP8rduZSJB1lX pWEQ== X-Gm-Message-State: AOPr4FUFFVrjSeJMv3596iEGJkXRPNDMRrBDvMtbEf746B/egA4RmLc8rmihyakeAZiHKMe+2efBL1vpbvg/tw== MIME-Version: 1.0 X-Received: by 10.202.58.133 with SMTP id h127mr8450644oia.59.1463975801991; Sun, 22 May 2016 20:56:41 -0700 (PDT) Received: by 10.182.78.138 with HTTP; Sun, 22 May 2016 20:56:41 -0700 (PDT) In-Reply-To: References: <20160507070925.GA2295@home.opsec.eu> Date: Mon, 23 May 2016 12:56:41 +0900 Message-ID: Subject: Re: new port for review: LDAP Authenticator plugin for MySQL From: Ganbold Tsagaankhuu To: freebsd-ports@freebsd.org Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.22 X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 May 2016 03:56:43 -0000 Hi, On Mon, May 9, 2016 at 3:37 PM, Ganbold Tsagaankhuu wrote: > Hi, > > On Sun, May 8, 2016 at 12:28 PM, Ganbold Tsagaankhuu > wrote: > >> Hi, >> >> On Sat, May 7, 2016 at 4:09 PM, Kurt Jaeger wrote: >> >>> Hi! >>> >>> > Can anyone take a look or review new port at >>> > https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=208913 ? >>> > This is LDAP Authenticator plugin for MySQL. >>> >>> One important thing: new ports should be submitted as shar-file. >>> >>> There are several issues, which running >>> >>> cd >>> portlint -AC >>> >>> flags. >> >> >> >> In my case portent -AC shows "pkg-descr: exceeds 24 lines, make it >> shorter if possible.(currently 39 lines)" >> I will fix that. >> >> >> >>> One other thing that sticks out: Is it really necessary to have >>> the ateam prefix for the port ? >>> >> >> >> Yes, we can't remove the A-Team part because then the project name is >> basically the same as the project we forked. We need it there to >> differentiate. >> > > I'm open to discuss on the name of the port, initially I thought it would > be better to have different name than the original project. > Please let me know. > > Any update on reviewing this new port PR? thanks a lot, Ganbold > thanks, > > Ganbold > > > > > >> >> >> >>> >>> I've added a shar of the modified port to the PR, which still >>> does not yet fetch and build. Can you provide a version 1.0 >>> on github that we can fetch ? >>> >> >> >> Should it necessarily does have version 1.0 in github? Can't it >> use GH_TAGNAME ? >> >> thanks, >> >> Ganbold >> >> >> >>> >>> Btw, I've created the shar with: >>> >>> shar `find mysql-ldap-auth -print` > /tmp/ldap.shar >>> >>> -- >>> pi@opsec.eu +49 171 3101372 4 years >>> to go ! >>> >> >> >