From owner-svn-src-head@freebsd.org Thu Mar 14 20:14:21 2019 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id EA736152AE24; Thu, 14 Mar 2019 20:14:20 +0000 (UTC) (envelope-from bzeeb-lists@lists.zabbadoz.net) Received: from mx1.sbone.de (mx1.sbone.de [IPv6:2a01:4f8:13b:39f::9f:25]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mx1.sbone.de", Issuer "SBone.DE" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 88BB56A77E; Thu, 14 Mar 2019 20:14:20 +0000 (UTC) (envelope-from bzeeb-lists@lists.zabbadoz.net) Received: from mail.sbone.de (mail.sbone.de [IPv6:fde9:577b:c1a9:31::2013:587]) (using TLSv1 with cipher ADH-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by mx1.sbone.de (Postfix) with ESMTPS id C83A58D4A13E; Thu, 14 Mar 2019 20:14:17 +0000 (UTC) Received: from content-filter.sbone.de (content-filter.sbone.de [IPv6:fde9:577b:c1a9:31::2013:2742]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.sbone.de (Postfix) with ESMTPS id C275CE708AD; Thu, 14 Mar 2019 20:14:16 +0000 (UTC) X-Virus-Scanned: amavisd-new at sbone.de Received: from mail.sbone.de ([IPv6:fde9:577b:c1a9:31::2013:587]) by content-filter.sbone.de (content-filter.sbone.de [fde9:577b:c1a9:31::2013:2742]) (amavisd-new, port 10024) with ESMTP id 5deJnCjYqtUV; Thu, 14 Mar 2019 20:14:15 +0000 (UTC) Received: from [192.168.2.110] (unknown [IPv6:fde9:577b:c1a9:31:2ef0:eeff:fe03:ee34]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.sbone.de (Postfix) with ESMTPSA id 2C413E708AC; Thu, 14 Mar 2019 20:14:15 +0000 (UTC) From: "Bjoern A. Zeeb" To: "Kyle Evans" Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r345151 - head/sys/net Date: Thu, 14 Mar 2019 20:14:14 +0000 X-Mailer: MailMate (2.0BETAr6135) Message-ID: <51089C2A-A135-445E-B733-02654C5F8B68@lists.zabbadoz.net> In-Reply-To: <201903141948.x2EJmhvY075110@repo.freebsd.org> References: <201903141948.x2EJmhvY075110@repo.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 88BB56A77E X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.99 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-1.00)[-0.995,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; REPLY(-4.00)[] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 14 Mar 2019 20:14:21 -0000 On 14 Mar 2019, at 19:48, Kyle Evans wrote: > Author: kevans > Date: Thu Mar 14 19:48:43 2019 > New Revision: 345151 > URL: https://svnweb.freebsd.org/changeset/base/345151 > > Log: > ether_fakeaddr: Use 'b' 's' 'd' for the prefix > > This has the advantage of being obvious to sniff out the designated > prefix > by eye and it has all the right bits set. Comment stolen from ffec. > > I've removed bryanv@'s pending question of using the FreeBSD OUI > range -- > no one has followed up on this with a definitive action, and there's > no > particular reason to shoot for it and the administrative overhead > that comes > with deciding exactly how to use it. Yay. iflib_gen_mac() has already thought kind-of similar and just took the entire(?) FreeBSD space for doing the same. That code should be merged as well. Bhyve is using a good chunk from the FreeBSD allocation; see sys/net/ieee_oui.h also for allocation guidelines (if I don’t misremember). The fact that it might need figuring out should not prevent us from doing it right .. the third time .. maybe .. this time? epair(4) is yet another one of the cloned interfaces which does magic for the ethernet addresses, not sure what else. /bz