Date: Tue, 18 Jun 2019 02:36:24 +0000 From: bugzilla-noreply@freebsd.org To: enlightenment@FreeBSD.org Subject: E on FreeBSD: maintainer-feedback requested: [Bug 238677] devel/efl: Leaks event monitor fds into child processes Message-ID: <bug-238677-33756-NvG8PAzeUj@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-238677-33756@https.bugs.freebsd.org/bugzilla/> References: <bug-238677-33756@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
Bugzilla Automation <bugzilla@FreeBSD.org> has asked freebsd-enlightenment mailing list <enlightenment@FreeBSD.org> for maintainer-feedback: Bug 238677: devel/efl: Leaks event monitor fds into child processes https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D238677 --- Description --- Please see the full report text in this upstream issue: https://phab.enlightenment.org/T7486 The fix is trivial -- add O_CLOEXEC to an open. I thought upstream might f= ix it, but it does not appear they will. So we might consider patching it in ports. The patch to fix is totally trivial: --- ./eio_monitor_kevent.c.orig 2019-06-17 19:34:47.015700000 -0700 +++ ./eio_monitor_kevent.c 2019-06-17 19:35:04.938381000 -0700 @@ -271,7 +271,7 @@ res =3D stat(monitor->path, &st); if (res) goto error; - fd =3D open(monitor->path, O_RDONLY); + fd =3D open(monitor->path, O_RDONLY | O_CLOEXEC); if (fd < 0) goto error; backend->fd =3D fd;
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-238677-33756-NvG8PAzeUj>