From owner-cvs-all@FreeBSD.ORG Fri Feb 12 15:34:26 2010 Return-Path: Delivered-To: cvs-all@FreeBSD.org Received: by hub.freebsd.org (Postfix, from userid 1033) id E8DD1106566C; Fri, 12 Feb 2010 15:34:26 +0000 (UTC) Date: Fri, 12 Feb 2010 15:34:26 +0000 From: Alexey Dokuchaev To: "Philip M. Gollucci" Message-ID: <20100212153426.GA82271@FreeBSD.org> References: <201002092323.o19NNRvB090976@repoman.freebsd.org> <20100210092407.GA30717@FreeBSD.org> <20100210125022.GD1538@hades.panopticon> <4B749F6E.5020806@FreeBSD.org> <4B749FFB.80506@p6m7g8.com> Mime-Version: 1.0 Content-Type: text/plain; charset=koi8-r Content-Disposition: inline In-Reply-To: <4B749FFB.80506@p6m7g8.com> User-Agent: Mutt/1.4.2.1i Cc: cvs-ports@FreeBSD.org, Doug Barton , cvs-all@FreeBSD.org, Dmitry Marakasov , ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/audio Makefile ports/audio/deadbeef Makefile distinfo pkg-descr pkg-plist ports/audio/deadbeef/files patch-Makefile.am patch-Makefile.in patch-configure patch-configure.ac X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: **OBSOLETE** CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 12 Feb 2010 15:34:27 -0000 On Thu, Feb 11, 2010 at 07:25:31PM -0500, Philip M. Gollucci wrote: > ... that we *try* to always patch the .am/.ac files and use > USE_AUTOTOOLS to re-generate the .in files. Only if resulting .in patch is overly complicated and/or large, which occasionally happens with auto-generated contents. In this case, if patching original (e.g. .am) can result in smaller diff, it is preferred over .in patching (doing it also makes the port to require USE_AUTOTOOLS, quite naturally). If simple .in patch is enough, there is no much point to force our users to pull shitware (which autotools is perfect example of) just to build the port. ./danfe