From owner-freebsd-scsi@FreeBSD.ORG Thu Mar 8 22:49:56 2012 Return-Path: Delivered-To: freebsd-scsi@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id CFA97106564A for ; Thu, 8 Mar 2012 22:49:56 +0000 (UTC) (envelope-from chuck@tuffli.net) Received: from mail-yw0-f54.google.com (mail-yw0-f54.google.com [209.85.213.54]) by mx1.freebsd.org (Postfix) with ESMTP id 9672C8FC13 for ; Thu, 8 Mar 2012 22:49:56 +0000 (UTC) Received: by yhgm50 with SMTP id m50so684620yhg.13 for ; Thu, 08 Mar 2012 14:49:50 -0800 (PST) MIME-Version: 1.0 Received: by 10.60.25.37 with SMTP id z5mr3092831oef.69.1331246989958; Thu, 08 Mar 2012 14:49:49 -0800 (PST) Received: by 10.60.67.226 with HTTP; Thu, 8 Mar 2012 14:49:49 -0800 (PST) In-Reply-To: <20120308211455.GA85033@nargothrond.kdm.org> References: <20120308211455.GA85033@nargothrond.kdm.org> Date: Thu, 8 Mar 2012 14:49:49 -0800 Message-ID: From: Chuck Tuffli To: "Kenneth D. Merry" Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-Gm-Message-State: ALoCoQkWrNlTg6qdImyOWG4n0atQd5z/4Pdgq7H55X1J0yLROnnkQARihxhe3zi5LXzL0w0Zf+Sx Cc: freebsd-scsi Subject: Re: CTL panic X-BeenThere: freebsd-scsi@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SCSI subsystem List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 Mar 2012 22:49:56 -0000 On Thu, Mar 8, 2012 at 1:14 PM, Kenneth D. Merry wrote: > On Thu, Feb 23, 2012 at 13:44:10 -0800, Chuck Tuffli wrote: >> I just tried using our targ(9) compatible driver with CTL today and >> get the below panic. Our driver didn't recognize the >> XPT_IMMEDIATE_NOTIFY and returned CAM_REQ_INVALID which ctlfedone >> doesn't handle explicitly. The following patch seems to avoid this >> problem for me, but there might be a better fix. > > Sorry for the delayed response. No worries > Here is a patch that should fix it. =A0Although it isn't relevant for you > now, since your driver is talking to CTL successfully, it is still needed > for the mpt(4), ahc(4), ahd(4), and firewire drivers that support the old= er > target mode API. > > This hopefully fixes some of the issues inside CTL, and then essentially > prevents CTL from talking to target-capable SIMs that haven't been update= d > to support the CCBs that CTL needs. I tested this patch using our driver both - with PIT_PROCESSOR set and no XPT_IMMEDIATE_NOTIFY support - with PIT_PROC_CTL set and XPT_IMMEDIATE_NOTIFY support and both work as expected. So patch-wise, ACK / "works for me" ---chuck