Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 6 Jan 2024 08:31:51 GMT
From:      Dimitry Andric <dim@FreeBSD.org>
To:        ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org, dev-commits-ports-main@FreeBSD.org
Subject:   git: b6807b43f161 - main - devel/libgudev: fix build with clang 18
Message-ID:  <202401060831.4068VpWA069084@gitrepo.freebsd.org>

next in thread | raw e-mail | index | archive | help
The branch main has been updated by dim:

URL: https://cgit.FreeBSD.org/ports/commit/?id=b6807b43f161c18a6d7a5642f817e4bff858d33a

commit b6807b43f161c18a6d7a5642f817e4bff858d33a
Author:     Dimitry Andric <dim@FreeBSD.org>
AuthorDate: 2024-01-05 23:28:08 +0000
Commit:     Dimitry Andric <dim@FreeBSD.org>
CommitDate: 2024-01-06 08:30:56 +0000

    devel/libgudev: fix build with clang 18
    
    Clang 18 no longer accepts -export-dynamic, which is a linker option,
    resulting in an error building devel/libgudev:
    
      cc  -o gudev/libgudev-1.0.so.0.3.0 gudev/libgudev-1.0.so.0.3.0.p/meson-generated_.._gudevenumtypes.c.o gudev/libgudev-1.0.so.0.3.0.p/gudevclient.c.o gudev/libgudev-1.0.so.0.3.0.p/gudevdevice.c.o gudev/libgudev-1.0.so.0.3.0.p/gudevenumerator.c.o -Wl,--as-needed -Wl,--no-undefined -Wl,-O1 -shared -fPIC -Wl,--start-group -Wl,-soname,libgudev-1.0.so.0 -fstack-protector-strong -O2 -pipe -fstack-protector-strong -fno-strict-aliasing -Wl,-rpath,/usr/local/lib -Wl,-rpath-link,/usr/local/lib -export-dynamic -Wl,--version-script,/wrkdirs/share/dim/ports/devel/libgudev/work/libgudev-237/libgudev-1.0.sym /usr/local/lib/libglib-2.0.so /usr/local/lib/libintl.so /usr/local/lib/libgobject-2.0.so /usr/local/lib/libudev.so -Wl,--end-group
      cc: error: unknown argument: '-export-dynamic'
    
    Fix this by using the correct spelling, -Wl,--export-dynamic.
    
    PR:             276135
    Approved by:    x11 (manu)
    MFH:            2024Q1
---
 devel/libgudev/Makefile | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/devel/libgudev/Makefile b/devel/libgudev/Makefile
index 6d9083030bac..f6bb93882a71 100644
--- a/devel/libgudev/Makefile
+++ b/devel/libgudev/Makefile
@@ -32,6 +32,9 @@ VALA_MESON_ENABLED=	vapi
 VALA_BUILD_DEPENDS=	vapigen:lang/vala
 VALA_VARS=		USE+=vala:build
 
+post-patch:
+	@${REINPLACE_CMD} -e 's|-export-dynamic|-Wl,--export-dynamic|' ${WRKSRC}/gudev/meson.build
+
 add-plist-docs: ${STAGE_COOKIE}
 	cd ${STAGEDIR}; ${FIND} ${DOCSDIR:C@^/@@} -type f | ${SED} -e 's@^@/@' >> ${TMPPLIST}
 	cd ${STAGEDIR}; ${FIND} ${LOCALBASE:C@^/@@}/share/gtk-doc/html -mindepth 2 -type f | ${SED} -e 's@^@/@' >> ${TMPPLIST}



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202401060831.4068VpWA069084>