From owner-freebsd-bugs@FreeBSD.ORG Wed Sep 21 12:50:06 2011 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 267381065670 for ; Wed, 21 Sep 2011 12:50:06 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id D71E58FC0C for ; Wed, 21 Sep 2011 12:50:05 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id p8LCo5tG098181 for ; Wed, 21 Sep 2011 12:50:05 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.4/8.14.4/Submit) id p8LCo5sP098180; Wed, 21 Sep 2011 12:50:05 GMT (envelope-from gnats) Resent-Date: Wed, 21 Sep 2011 12:50:05 GMT Resent-Message-Id: <201109211250.p8LCo5sP098180@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Henning Petersen Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 53FC5106564A for ; Wed, 21 Sep 2011 12:46:53 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22]) by mx1.freebsd.org (Postfix) with ESMTP id 4450E8FC08 for ; Wed, 21 Sep 2011 12:46:53 +0000 (UTC) Received: from red.freebsd.org (localhost [127.0.0.1]) by red.freebsd.org (8.14.4/8.14.4) with ESMTP id p8LCkqpg003231 for ; Wed, 21 Sep 2011 12:46:52 GMT (envelope-from nobody@red.freebsd.org) Received: (from nobody@localhost) by red.freebsd.org (8.14.4/8.14.4/Submit) id p8LCkq3G003230; Wed, 21 Sep 2011 12:46:52 GMT (envelope-from nobody) Message-Id: <201109211246.p8LCkq3G003230@red.freebsd.org> Date: Wed, 21 Sep 2011 12:46:52 GMT From: Henning Petersen To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Cc: Subject: misc/160866: Swapped arguments in fifo_misc.c X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Sep 2011 12:50:06 -0000 >Number: 160866 >Category: misc >Synopsis: Swapped arguments in fifo_misc.c >Confidential: no >Severity: non-critical >Priority: medium >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Wed Sep 21 12:50:05 UTC 2011 >Closed-Date: >Last-Modified: >Originator: Henning Petersen >Release: FreeBSD-current >Organization: >Environment: >Description: Swapped arguments in fifo_misc.c . >How-To-Repeat: >Fix: diff -u -r1.6 fifo_misc.c --- tools/regression/fifo/fifo_misc/fifo_misc.c 31 Dec 2009 20:29:58 -0000 1.6 +++ tools/regression/fifo/fifo_misc/fifo_misc.c 21 Sep 2011 08:50:14 -0000 @@ -115,7 +115,7 @@ exit(-1); } - if (lseek(reader_fd, SEEK_CUR, 1) >= 0) { + if (lseek(reader_fd, 1, SEEK_CUR) >= 0) { warnx("%s: lseek succeeded instead of returning ESPIPE", __func__); cleanfifo("testfifo", reader_fd, writer_fd); Patch attached with submission follows: diff -u -r1.6 fifo_misc.c --- tools/regression/fifo/fifo_misc/fifo_misc.c 31 Dec 2009 20:29:58 -0000 1.6 +++ tools/regression/fifo/fifo_misc/fifo_misc.c 21 Sep 2011 08:50:14 -0000 @@ -115,7 +115,7 @@ exit(-1); } - if (lseek(reader_fd, SEEK_CUR, 1) >= 0) { + if (lseek(reader_fd, 1, SEEK_CUR) >= 0) { warnx("%s: lseek succeeded instead of returning ESPIPE", __func__); cleanfifo("testfifo", reader_fd, writer_fd); >Release-Note: >Audit-Trail: >Unformatted: