Date: Tue, 4 Dec 2012 16:06:40 +0100 From: Baptiste Daroussin <bapt@FreeBSD.org> To: "Jason E. Hale" <jhale@freebsd.org> Cc: svn-ports-head@freebsd.org, Gabor Pali <pgj@freebsd.org>, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r308217 - in head/devel/icmake: . files Message-ID: <20121204150639.GA29641@ithaqua.etoilebsd.net> In-Reply-To: <3751237.XETYxtBKI8@mocha.verizon.net> References: <201212040913.qB49DUfk028183@svn.freebsd.org> <1837268.Hp4WNQ0tny@mocha.verizon.net> <CAHnG2Cx6rS9QgJk=YvmqtZxq4qTu2joTP_7vZu8XopZHQFb13g@mail.gmail.com> <3751237.XETYxtBKI8@mocha.verizon.net>
next in thread | previous in thread | raw e-mail | index | archive | help
--SUOF0GtieIMvvwua
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
On Tue, Dec 04, 2012 at 08:46:58AM -0500, Jason E. Hale wrote:
> On Tuesday, December 04, 2012 13:23:41 Gabor Pali wrote:
> > On Tue, Dec 4, 2012 at 12:45 PM, Jason E. Hale <jhale@freebsd.org> wrot=
e:
> >=20
> > >> .if !defined(NOPORTDOCS)
> > >=20
> > > Should convert to ${PORT_OPTIONS:MDOCS}
> >=20
> > Hrm, I did not find any authoritative guidance on this. Once I asked
> > bapt about this, and he told me that keeping NOPORTDOCS is okay, if I
> > recall correctly.
> >=20
> Maybe bapt can comment, but we seem to be converting everything to OPTION=
Sng. =20
> This includes NOPORTDOCS, NOPORTEXAMPLES, WITHOUT_NLS, etc. AFAIK the pr=
ioity=20
> is to convert ports that use the old OPTIONS, but it would be good to con=
vert=20
> the other variables as well if the opportunity arises.
> http://wiki.freebsd.org/Ports/Options/ConvertingToOptionsNG
> includes a check for all of those.
>=20
Nothing has been written in stone yet about this, because the priority was =
to
convert ports to new options framework first, to be able to kill KNOBS etc =
and
then to work on converting NOPORTDOCS, NOPORTEXAMPLES and WITHOUT_NLS, that=
is
why I told Gabor he can do what ever he thinks is best in that case.
Of course converting now NOPORTDOCS to PORT_OPTIONS:DOCS, NOPORTEXAMPLES to
PORT_OPTIONS:MEXAMPLES and NLS to PORT_OPTIONS:MNLS brings more consistency=
so I
personnaly thinks it is preferable.
So last reason for not having pushed yet a rule on that is, that NOPORTDOCS,
NOPORTEXAMPLES and WITHOUT_NLS are specified on lots of documentation that =
needs
to be updated and I have currently no time for that.
That is another area that is open to volunteer btw :)
regards,
Bapt
--SUOF0GtieIMvvwua
Content-Type: application/pgp-signature
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.19 (FreeBSD)
iEYEARECAAYFAlC+EX8ACgkQ8kTtMUmk6EwsMgCdFEEFxh49oNn5pQbj6vuDxYy5
mLYAnRp+LiqK8TOXYbwdnfTVBbTpTfy3
=oW/F
-----END PGP SIGNATURE-----
--SUOF0GtieIMvvwua--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20121204150639.GA29641>