From owner-svn-ports-all@FreeBSD.ORG Tue Dec 4 15:06:45 2012 Return-Path: Delivered-To: svn-ports-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 4705B2E3; Tue, 4 Dec 2012 15:06:45 +0000 (UTC) (envelope-from baptiste.daroussin@gmail.com) Received: from mail-ee0-f54.google.com (mail-ee0-f54.google.com [74.125.83.54]) by mx1.freebsd.org (Postfix) with ESMTP id 1A2A68FC15; Tue, 4 Dec 2012 15:06:43 +0000 (UTC) Received: by mail-ee0-f54.google.com with SMTP id c13so2835865eek.13 for ; Tue, 04 Dec 2012 07:06:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=3CweckM4Tos/VQD7AqSV07KaHruF5jgqQTMfagqH7Dw=; b=at6AxvQ12PZ+ytXiZN+73EmVxuCM82Omn1rz4DG6qSlwSl/+9tE8jZMinYyZjw2ozp G/nmZw42pxK8TroQ+xN/rSHXerT88Wt8TmxgFLMjHzUWz+Y8zHYy5EQWCpb/u5skC9cd YUp2vtYmkrsQawHDLx3k9xLIX4uCFKXbCCw2OaiVVattBpe17NqJ9vEAVEUcgmgqJSsW hRq5FRuFlKtMMr9e1PdefNcjlFYsnj2b4j3TEjxXncrVbSz3FYxn760ANbiWpBpkBdcc lkGsVq8XyqK+uKEXvvy60UQEEU7zVFt60ewILo2COstOrS3fMuYVzoNPxf8PJhAjq8U1 ewMg== Received: by 10.14.3.195 with SMTP id 43mr49416816eeh.36.1354633602731; Tue, 04 Dec 2012 07:06:42 -0800 (PST) Received: from ithaqua.etoilebsd.net (ithaqua.etoilebsd.net. [37.59.37.188]) by mx.google.com with ESMTPS id w3sm3028687eel.17.2012.12.04.07.06.41 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 04 Dec 2012 07:06:41 -0800 (PST) Sender: Baptiste Daroussin Date: Tue, 4 Dec 2012 16:06:40 +0100 From: Baptiste Daroussin To: "Jason E. Hale" Subject: Re: svn commit: r308217 - in head/devel/icmake: . files Message-ID: <20121204150639.GA29641@ithaqua.etoilebsd.net> References: <201212040913.qB49DUfk028183@svn.freebsd.org> <1837268.Hp4WNQ0tny@mocha.verizon.net> <3751237.XETYxtBKI8@mocha.verizon.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="SUOF0GtieIMvvwua" Content-Disposition: inline In-Reply-To: <3751237.XETYxtBKI8@mocha.verizon.net> User-Agent: Mutt/1.5.21 (2010-09-15) Cc: svn-ports-head@freebsd.org, Gabor Pali , svn-ports-all@freebsd.org, ports-committers@freebsd.org X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 04 Dec 2012 15:06:45 -0000 --SUOF0GtieIMvvwua Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Dec 04, 2012 at 08:46:58AM -0500, Jason E. Hale wrote: > On Tuesday, December 04, 2012 13:23:41 Gabor Pali wrote: > > On Tue, Dec 4, 2012 at 12:45 PM, Jason E. Hale wrot= e: > >=20 > > >> .if !defined(NOPORTDOCS) > > >=20 > > > Should convert to ${PORT_OPTIONS:MDOCS} > >=20 > > Hrm, I did not find any authoritative guidance on this. Once I asked > > bapt about this, and he told me that keeping NOPORTDOCS is okay, if I > > recall correctly. > >=20 > Maybe bapt can comment, but we seem to be converting everything to OPTION= Sng. =20 > This includes NOPORTDOCS, NOPORTEXAMPLES, WITHOUT_NLS, etc. AFAIK the pr= ioity=20 > is to convert ports that use the old OPTIONS, but it would be good to con= vert=20 > the other variables as well if the opportunity arises. > http://wiki.freebsd.org/Ports/Options/ConvertingToOptionsNG > includes a check for all of those. >=20 Nothing has been written in stone yet about this, because the priority was = to convert ports to new options framework first, to be able to kill KNOBS etc = and then to work on converting NOPORTDOCS, NOPORTEXAMPLES and WITHOUT_NLS, that= is why I told Gabor he can do what ever he thinks is best in that case. Of course converting now NOPORTDOCS to PORT_OPTIONS:DOCS, NOPORTEXAMPLES to PORT_OPTIONS:MEXAMPLES and NLS to PORT_OPTIONS:MNLS brings more consistency= so I personnaly thinks it is preferable. So last reason for not having pushed yet a rule on that is, that NOPORTDOCS, NOPORTEXAMPLES and WITHOUT_NLS are specified on lots of documentation that = needs to be updated and I have currently no time for that. That is another area that is open to volunteer btw :) regards, Bapt --SUOF0GtieIMvvwua Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (FreeBSD) iEYEARECAAYFAlC+EX8ACgkQ8kTtMUmk6EwsMgCdFEEFxh49oNn5pQbj6vuDxYy5 mLYAnRp+LiqK8TOXYbwdnfTVBbTpTfy3 =oW/F -----END PGP SIGNATURE----- --SUOF0GtieIMvvwua--