From owner-svn-src-head@freebsd.org Thu Jun 28 19:35:12 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 1D7521025382 for ; Thu, 28 Jun 2018 19:35:12 +0000 (UTC) (envelope-from ed@nuxi.nl) Received: from mail-ed1-x534.google.com (mail-ed1-x534.google.com [IPv6:2a00:1450:4864:20::534]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 77FD28A768 for ; Thu, 28 Jun 2018 19:35:10 +0000 (UTC) (envelope-from ed@nuxi.nl) Received: by mail-ed1-x534.google.com with SMTP id m15-v6so5847295edr.7 for ; Thu, 28 Jun 2018 12:35:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuxi-nl.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=lQl/Ljrrram5iEnZu8yGf8ReQuDJgmeET/bqmi1nAbI=; b=HMCsefzpREsmb53qPs/k4gHaVkCAw0uEHMq4EVFHlSEeK0jqXM6imn1rp2NeAJMIvp KsFOfAOnd2PwqfMLmKMaxvmBJtWW4V/Jf5mVVfECayWxcbTTxTPkOM+OVlKCbL41yoj9 PYvDylpkPgL6xVYt6h2p1eMBXBZDK8EFqIxOnq7IUZs2dxZSkb8j6XYa/X4g8KBISfpA 3tz/U1RavRnQKewzW/vX+H57viWsRMf7eKOY6IIYvvhI8ppPgtYB+XJsyDG97lvB7y8Z voP9zhiimD9zvKUo2LdhTSyzvjdyC1cm3drDFuZFjC79Ht8ARM/qjBOEi3BIYyDHiN/h dWnQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=lQl/Ljrrram5iEnZu8yGf8ReQuDJgmeET/bqmi1nAbI=; b=cPwtmBTU8DXcDS268yHsfzqmRm2tdLMQexsRGIO+7PN3LRBQElfJTA6E1nQPgoUVt/ +VR7TeqxtOwRyC6BdeOnOuS8nu4Y6tKNmVJb4Rv8O9ZacNJXqdWNjtiN9lfnr9OWjSQ/ r2wmfV9WNc+ZCnnPafu9EIyIvzHYC1j8e72YAAMS0RUF9DND0rIyunWcPJcfAygpEbV5 SdOP/K48NXi8BB0LTehzolqEV285+N/J/XSpi7+FBXDpeWXtBQlK4IMVqQ/5k0UAnpaY ZhADrEIK5i3wDFiaYareAOVdBOfaWVTQ6UXKZYd6DUftQHHUZZUvB/gNtegQ5b49CBJT tnVA== X-Gm-Message-State: APt69E3P718loTaIeJVzzgc+2l5wvue/tmcqZFIPOam6kJ6tCs9J5nub keqGvTlzP6nn7vU84601CZ1NkYps6X82suEeQdyNOA== X-Google-Smtp-Source: AAOMgpdJzN9wkS3e+sVEz/NV0M2n61TbaFvOJPd0nZ1ehG7cbuYGc86YBYRL+zgCXVZkU/1DtCW9rhWWmHtRpJp/jdk= X-Received: by 2002:a50:d1c1:: with SMTP id i1-v6mr10624626edg.122.1530214509702; Thu, 28 Jun 2018 12:35:09 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a50:8e0d:0:0:0:0:0 with HTTP; Thu, 28 Jun 2018 12:34:38 -0700 (PDT) In-Reply-To: <201806281701.w5SH15eP011261@repo.freebsd.org> References: <201806281701.w5SH15eP011261@repo.freebsd.org> From: Ed Schouten Date: Thu, 28 Jun 2018 21:34:38 +0200 Message-ID: Subject: Re: svn commit: r335765 - head/sys/sys To: David Bright Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 28 Jun 2018 19:35:12 -0000 Hi David, 2018-06-28 19:01 GMT+02:00 David Bright : > +#define EV_SET(kevp_, a, b, c, d, e, f) do { \ Some time ago I also looked into this and realised that it may even be possible to do something like this: static __inline void EV_SET(...) { } /* Compatibility for code that tests #ifdef EV_SET. */ #define EV_SET EV_SET This has the advantage that you get pretty neat error messages in case you get the typing of arguments wrong, as if you're just calling a function incorrectly. The EV_SET() macro is never used in contexts that require constant values. -- Ed Schouten Nuxi, 's-Hertogenbosch, the Netherlands