From owner-freebsd-bugs@FreeBSD.ORG  Wed Aug  3 10:00:31 2011
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 0E4A3106566B
	for <freebsd-bugs@hub.freebsd.org>;
	Wed,  3 Aug 2011 10:00:31 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
	[IPv6:2001:4f8:fff6::28])
	by mx1.freebsd.org (Postfix) with ESMTP id F26028FC16
	for <freebsd-bugs@hub.freebsd.org>;
	Wed,  3 Aug 2011 10:00:30 +0000 (UTC)
Received: from freefall.freebsd.org (localhost [127.0.0.1])
	by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id p73A0USh084580
	for <freebsd-bugs@freefall.freebsd.org>; Wed, 3 Aug 2011 10:00:30 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.14.4/8.14.4/Submit) id p73A0UDs084579;
	Wed, 3 Aug 2011 10:00:30 GMT (envelope-from gnats)
Date: Wed, 3 Aug 2011 10:00:30 GMT
Message-Id: <201108031000.p73A0UDs084579@freefall.freebsd.org>
To: freebsd-bugs@FreeBSD.org
From: dfilter@FreeBSD.ORG (dfilter service)
Cc: 
Subject: Re: bin/158431: commit references a PR
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: dfilter service <dfilter@FreeBSD.ORG>
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 03 Aug 2011 10:00:31 -0000

The following reply was made to PR bin/158431; it has been noted by GNATS.

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: bin/158431: commit references a PR
Date: Wed,  3 Aug 2011 09:56:08 +0000 (UTC)

 Author: avg
 Date: Wed Aug  3 09:55:59 2011
 New Revision: 224632
 URL: http://svn.freebsd.org/changeset/base/224632
 
 Log:
   fix a serious bug in libproc's proc_attach
   
   proc_attach always frees any struct proc_handle data
   that it allocates, but that is supposed to be done
   only in error conditions.
   
   PR:		bin/158431
   Approved by:	re (kib)
   MFC after:	1 week
 
 Modified:
   head/lib/libproc/proc_create.c
 
 Modified: head/lib/libproc/proc_create.c
 ==============================================================================
 --- head/lib/libproc/proc_create.c	Wed Aug  3 09:42:48 2011	(r224631)
 +++ head/lib/libproc/proc_create.c	Wed Aug  3 09:55:59 2011	(r224632)
 @@ -79,12 +79,11 @@ proc_attach(pid_t pid, int flags, struct
  	else
  		phdl->status = PS_STOP;
  
 +out:
  	if (error)
  		proc_free(phdl);
  	else
  		*pphdl = phdl;
 -out:
 -	proc_free(phdl);
  	return (error);
  }
  
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"