Date: Thu, 24 Mar 2022 02:43:18 +0000 From: Alexey Dokuchaev <danfe@freebsd.org> To: Neel Chauhan <nc@freebsd.org> Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: 52bcb8cd9f26 - main - net/libgweather4: Don't use PORTSUFFIX Message-ID: <YjvaxuJevGpjK8/o@FreeBSD.org> In-Reply-To: <202203231752.22NHqbd3058172@gitrepo.freebsd.org> References: <202203231752.22NHqbd3058172@gitrepo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Mar 23, 2022 at 05:52:37PM +0000, Neel Chauhan wrote:
> commit 52bcb8cd9f26bc2f49bdeb4c1cbe5b3c64342fbf
>
> net/libgweather4: Don't use PORTSUFFIX
Why???
> @@ -1,10 +1,10 @@
> -PORTNAME= libgweather
> +PORTNAME= libgweather4
> PORTVERSION= 4.0.0
> CATEGORIES= net gnome
> MASTER_SITES= GNOME
> -MASTER_SITE_SUBDIR= sources/${PORTNAME}/${PORTVERSION:R}
> +MASTER_SITE_SUBDIR= sources/libgweather/${PORTVERSION:R}
> +DISTNAME= libgweather-${PORTVERSION}
> DIST_SUBDIR= gnome
> -PORTSUFFIX= 4
It was correct before, this is pretty standard way of how we keep and
annotate multi-version ports in the tree, embedding version in the
PORTNAME is wrong. Please revert.
./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?YjvaxuJevGpjK8/o>