From owner-freebsd-bugs@FreeBSD.ORG  Mon Dec  5 21:50:10 2011
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id E5301106566C
	for <freebsd-bugs@hub.freebsd.org>;
	Mon,  5 Dec 2011 21:50:10 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
	[IPv6:2001:4f8:fff6::28])
	by mx1.freebsd.org (Postfix) with ESMTP id D54AF8FC0A
	for <freebsd-bugs@hub.freebsd.org>;
	Mon,  5 Dec 2011 21:50:10 +0000 (UTC)
Received: from freefall.freebsd.org (localhost [127.0.0.1])
	by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id pB5LoAg6078207
	for <freebsd-bugs@freefall.freebsd.org>; Mon, 5 Dec 2011 21:50:10 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.14.5/8.14.5/Submit) id pB5LoAYt078206;
	Mon, 5 Dec 2011 21:50:10 GMT (envelope-from gnats)
Date: Mon, 5 Dec 2011 21:50:10 GMT
Message-Id: <201112052150.pB5LoAYt078206@freefall.freebsd.org>
To: freebsd-bugs@FreeBSD.org
From: Jaakko Heinonen <jh@FreeBSD.org>
Cc: 
Subject: Re: kern/163076: It is not possible to read in chunks from linprocfs
 and procfs.
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: Jaakko Heinonen <jh@FreeBSD.org>
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 05 Dec 2011 21:50:11 -0000

The following reply was made to PR kern/163076; it has been noted by GNATS.

From: Jaakko Heinonen <jh@FreeBSD.org>
To: Poul-Henning Kamp <phk@phk.freebsd.dk>
Cc: Petr Salinger <Petr.Salinger@seznam.cz>, bug-followup@FreeBSD.org
Subject: Re: kern/163076: It is not possible to read in chunks from linprocfs
 and procfs.
Date: Mon, 5 Dec 2011 23:42:02 +0200

 On 2011-12-05, Poul-Henning Kamp wrote:
 > >Yes, r222004 changed sbuf_finish() to not clear s->s_error which causes
 > >the regression. I am not sure if we should blame r222004 or the pseudofs
 > >code.
 > 
 > The sbuf code is correct.
 > 
 > Sbufs were designed to have "latching error semantics" and any errors
 > should not be cleared by sbuf_finish() for exactly that reason.
 
 Shouldn't sbuf_finish() then check s->s_error before appending the
 trailing '\0' and setting the SBUF_FINISHED flag? The problem in
 question wasn't caught earlier because sbuf_finish() happily finishes
 the buffer even if it has an error.
 
 -- 
 Jaakko