From owner-svn-src-head@freebsd.org Wed Jan 11 19:55:53 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 8F03CCABDC0; Wed, 11 Jan 2017 19:55:53 +0000 (UTC) (envelope-from bu7cher@yandex.ru) Received: from forward2o.cmail.yandex.net (forward2o.cmail.yandex.net [IPv6:2a02:6b8:0:1a72::287]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "forwards.mail.yandex.net", Issuer "Yandex CA" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 421481F90; Wed, 11 Jan 2017 19:55:53 +0000 (UTC) (envelope-from bu7cher@yandex.ru) Received: from smtp1m.mail.yandex.net (smtp1m.mail.yandex.net [IPv6:2a02:6b8:0:2519::121]) by forward2o.cmail.yandex.net (Yandex) with ESMTP id 3D527211C5; Wed, 11 Jan 2017 22:55:49 +0300 (MSK) Received: from smtp1m.mail.yandex.net (localhost.localdomain [127.0.0.1]) by smtp1m.mail.yandex.net (Yandex) with ESMTP id D0CDB63C0E22; Wed, 11 Jan 2017 22:55:47 +0300 (MSK) Received: by smtp1m.mail.yandex.net (nwsmtp/Yandex) with ESMTPSA id Vlj57T8Rnw-tl3WHPPh; Wed, 11 Jan 2017 22:55:47 +0300 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client certificate not present) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail; t=1484164547; bh=jTVXT12OrQGGk8wZIRHCzgG/SZ7+zGTVvrcA74azIto=; h=Subject:To:References:From:Message-ID:Date:In-Reply-To; b=mXSOvG/0TVU68/4XbDOWNrddLDjTcyYbog6r7gvc3vRRW5gQzgzV3/twgT1eyap5n Ex/pdaiY5Bhs7LCH9N5oTfpNPcsNsBbJnNp8ylEAgrfsjvOxyKXHzJUEu5xp0LcOm0 Fo8msXLQCI741N4NdX4DC2cjWTbPDO/V2AvK4UyU= Authentication-Results: smtp1m.mail.yandex.net; dkim=pass header.i=@yandex.ru X-Yandex-Suid-Status: 1 0,1 0,1 0,1 0 Subject: Re: svn commit: r311931 - head/sys/dev/e1000 To: Sean Bruno , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org References: <201701111929.v0BJTX4m030279@repo.freebsd.org> From: "Andrey V. Elsukov" Message-ID: <821fe1c5-8173-1f2d-f691-2d89eb8b0e69@yandex.ru> Date: Wed, 11 Jan 2017 22:54:58 +0300 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <201701111929.v0BJTX4m030279@repo.freebsd.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 11 Jan 2017 19:55:53 -0000 On 11.01.2017 22:29, Sean Bruno wrote: > Author: sbruno > Date: Wed Jan 11 19:29:33 2017 > New Revision: 311931 > URL: https://svnweb.freebsd.org/changeset/base/311931 > > Log: > Restore v6 offload caps for igb(4) class devices. > Modified: head/sys/dev/e1000/if_em.h > ============================================================================== > --- head/sys/dev/e1000/if_em.h Wed Jan 11 19:29:28 2017 (r311930) > +++ head/sys/dev/e1000/if_em.h Wed Jan 11 19:29:33 2017 (r311931) > @@ -330,7 +330,8 @@ > #define EM_MSIX_LINK 0x01000000 /* For 82574 use */ > #define ETH_ZLEN 60 > #define ETH_ADDR_LEN 6 > -#define CSUM_OFFLOAD 7 /* Offload bits in mbuf flag */ > +#define EM_CSUM_OFFLOAD 7 /* Offload bits in mbuf flag */ > +#define IGB_CSUM_OFFLOAD 0x0E0F /* Offload bits in mbuf flag */ Hi, Sean, why did you not define these masks using macros from sys/mbuf.h? It seems it would be more readable. -- WBR, Andrey V. Elsukov