From owner-freebsd-arch@FreeBSD.ORG Sat Feb 9 15:27:24 2013 Return-Path: Delivered-To: freebsd-arch@FreeBSD.org Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id 796C21D8 for ; Sat, 9 Feb 2013 15:27:24 +0000 (UTC) (envelope-from avg@FreeBSD.org) Received: from citadel.icyb.net.ua (citadel.icyb.net.ua [212.40.38.140]) by mx1.freebsd.org (Postfix) with ESMTP id C2A12F95 for ; Sat, 9 Feb 2013 15:27:23 +0000 (UTC) Received: from porto.starpoint.kiev.ua (porto-e.starpoint.kiev.ua [212.40.38.100]) by citadel.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id RAA21298; Sat, 09 Feb 2013 17:27:20 +0200 (EET) (envelope-from avg@FreeBSD.org) Received: from localhost ([127.0.0.1]) by porto.starpoint.kiev.ua with esmtp (Exim 4.34 (FreeBSD)) id 1U4CKm-00085B-3e; Sat, 09 Feb 2013 17:27:20 +0200 Message-ID: <51166AD5.4090707@FreeBSD.org> Date: Sat, 09 Feb 2013 17:27:17 +0200 From: Andriy Gapon User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:17.0) Gecko/20130121 Thunderbird/17.0.2 MIME-Version: 1.0 To: Chris Rees Subject: Re: Proposal: Unify printing the function name in panic messages() References: <51141E33.4080103@gmx.de> <511426B8.2070800@FreeBSD.org> <51160E06.1070404@gmx.de> <5116121E.1010601@FreeBSD.org> <511616AC.8080306@gmx.de> <511622A2.2090601@FreeBSD.org> In-Reply-To: X-Enigmail-Version: 1.4.6 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: freebsd-arch@FreeBSD.org X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 09 Feb 2013 15:27:24 -0000 on 09/02/2013 12:46 Chris Rees said the following: > > On 9 Feb 2013 10:19, "Andriy Gapon" > > wrote: >> >> on 09/02/2013 11:28 Christoph Mallon said the following: >> > On 09.02.2013 10:08, Andriy Gapon wrote: >> >> In any case, you just search the code for the message and that's it. >> > >> > Often the messages contains parameters (%d, %s, ...) or are split into > multiple lines to appease the ancient 80 columns god. >> > These make it harder to grep. >> > Having the /right/ name makes it easier to get to the right place. >> >> Having right tools for the search does that too. >> And doesn't require any code churn. > > OK, which tool can one find a panic message split across lines in source code? > I would find this very useful. http://grok.x12.su/source/search?q=%22offset+below+first+LBA%22&project=freebsd Generally, I like opengrok very much. Pity that we don't have an official server. fxr.watson.org is great, but opengrok is superior to glimpse. E.g. try the same kind of search here: http://fxr.watson.org/fxr/search BTW, a local version (slower because no index is used): $ pcregrep -r -M 'offset\W*below\W*first\W*LBA' sys/ sys/geom/part/g_part.c: DPRINTF("partition %d has start offset below first " "LBA: %jd < %jd\n", e1->gpe_index, pcregrep comes from devel/pcre. P.S. my first instinct was to try git grep first, git grep seems to support perl regular expressions in general, but it looks like the port doesn't include the necessary support: fatal: cannot use Perl-compatible regexes when not compiled with USE_LIBPCRE P.P.S. I must say that I use textproc/glimpse (with index weekly updated via cron) and in 99% of cases glimpse 'something' immediately returns useful results. It's quite rare that I have to use other tools for searching the code. I use vim + ctags too :-) -- Andriy Gapon