From nobody Sun Jun 9 07:08:25 2024 X-Original-To: dev-commits-ports-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4VxmHd1b5gz5NlVx for ; Sun, 09 Jun 2024 07:08:29 +0000 (UTC) (envelope-from daniel.engberg.lists@pyret.net) Received: from smtp-8fad.mail.infomaniak.ch (smtp-8fad.mail.infomaniak.ch [83.166.143.173]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "relay.mail.infomaniak.ch", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4VxmHc5wGcz4nfM for ; Sun, 9 Jun 2024 07:08:28 +0000 (UTC) (envelope-from daniel.engberg.lists@pyret.net) Authentication-Results: mx1.freebsd.org; none Received: from smtp-4-0001.mail.infomaniak.ch (smtp-4-0001.mail.infomaniak.ch [10.7.10.108]) by smtp-4-3000.mail.infomaniak.ch (Postfix) with ESMTPS id 4VxmHY4XSyzDyH; Sun, 9 Jun 2024 09:08:25 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pyret.net; s=20231006; t=1717916905; bh=H7uc/cgsYX8W8rnv23DrohMlCMaK3rH5UB7PsOnWDX4=; h=Date:Subject:From:Reply-To:To:Cc:References:In-Reply-To:From; b=YKJIuTVlFvvO2VgUnCjs7+d3PCERL/3DVpadtiuBPcIegOPIaw39v90J1or5oZPyz a0YSEWCZug8rCxLF4KmMV4kosx+Bq2WVcOjBShGd1rDV6Ei4JFepUbfw4xQWog4X+k DIiZALaz+vmTesTGdfiAs3Q1mkTP1XUfIGc6gnu2Ze2SpWfj/Vw2Pkqj4/zTZnhHeX UGZ2UJekGlgE1cYzowe2A7wAAMwjHYvFiRS1hrxy7pSBNQAdYTu3T6DpTYlD6N4wXL P8lxUVrV2QeRbKarYsfVDFRK2GaKihePmV259NF/22sX/AVYUDc/0934H0Wj3kHwfm wlNEWlECSAd0w== Received: from unknown by smtp-4-0001.mail.infomaniak.ch (Postfix) with ESMTPA id 4VxmHY2581z966; Sun, 9 Jun 2024 09:08:25 +0200 (CEST) Message-ID: <96134cbe563ec73933802de201a9b640@mail.infomaniak.com> Date: Sun, 09 Jun 2024 09:08:25 +0200 Subject: Re: git: 187b969b8f9f - main - graphics/svgpp: new port had been added (+) From: Daniel Engberg Reply-To: Daniel Engberg To: Alexey Dokuchaev Cc: ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org, dev-commits-ports-main@FreeBSD.org List-Id: Commit messages for all branches of the ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-ports-all@freebsd.org Sender: owner-dev-commits-ports-all@FreeBSD.org MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="_=_swift_1717916905_bbe7bf6c18b832e61f3c1280c76e39f8_=_" X-WS-User-Origin: eyJpdiI6Ikt2ZFYzb2N6MVR4MGQ5UHptVUxOWUE9PSIsInZhbHVlIjoiMGkrOWdKZzhDaTFGUCt4Qi9HS3QvQT09IiwibWFjIjoiOWU1OTM0MDU5Njk0Y2I3MGYwYjU1YmM2ZDc3MjY4YmEyZWI5NmFhY2E2MGQ1MTBkODNkMTRmMzBlOGYxNjYwNyIsInRhZyI6IiJ9 X-WS-User-Mbox: eyJpdiI6ImVoZzJmVUJINFZXK2YvNGpUZ3ljVHc9PSIsInZhbHVlIjoic0RmZ3lHMzc1ME5EakVKTHdZNEw3dz09IiwibWFjIjoiM2MxOGY5MDhhN2FkOWFiYTI0NmRjZGY2YTFlMTAyNjA3MTkwNTI3ODBjZDM0YWJjMTU5ZjhlNDljZTg4ZGIxZCIsInRhZyI6IiJ9 X-WS-Location: eJxzKUpMKykGAAfpAmU- X-Mailer: Infomaniak Workspace (1.3.694) References: <202406090626.4596QEei093326@gitrepo.freebsd.org> In-Reply-To: <202406090626.4596QEei093326@gitrepo.freebsd.org> X-Infomaniak-Routing: alpha X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:29222, ipnet:83.166.128.0/19, country:CH] X-Rspamd-Queue-Id: 4VxmHc5wGcz4nfM --_=_swift_1717916905_bbe7bf6c18b832e61f3c1280c76e39f8_=_ Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 2024-06-09T08:26:14.000+02:00, Alexey Dokuchaev wr= ote: >=C2=A0The=C2=A0branch=C2=A0main=C2=A0has=C2=A0been=C2=A0updated= =C2=A0by=C2=A0danfe: >=C2=A0 >=C2=A0URL:=C2=A0https://cgit.FreeBSD.org/= ports/commit/?id=3D187b969b8f9f0ed850f0dc7eb8d08b6d961f1346 >=C2=A0 >= =C2=A0commit=C2=A0187b969b8f9f0ed850f0dc7eb8d08b6d961f1346 >=C2=A0 >= =C2=A0Author:=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0Alexey=C2=A0Dokuchaev=C2=A0 >=C2=A0 >=C2=A0AuthorDate:=C2=A02024-06-09=C2=A006:25:00= =C2=A0+0000 >=C2=A0 >=C2=A0Commit:=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0Alexey= =C2=A0Dokuchaev=C2=A0 >=C2=A0 >=C2=A0CommitDate:= =C2=A02024-06-09=C2=A006:25:00=C2=A0+0000 >=C2=A0 >=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0graphics/svgpp:=C2=A0new=C2=A0port=C2=A0had=C2=A0been=C2= =A0added=C2=A0(+) >=C2=A0 >=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 >=C2=A0 >= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0SVG++=C2=A0library=C2=A0can=C2=A0be=C2=A0thou= ght=C2=A0of=C2=A0as=C2=A0a=C2=A0framework,=C2=A0containing=C2=A0parsers >= =C2=A0 >=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0for=C2=A0various=C2=A0SVG=C2=A0synt= axes,=C2=A0adapters=C2=A0that=C2=A0simplify=C2=A0handling=C2=A0of=C2=A0pars= ed >=C2=A0 >=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0data,=C2=A0and=C2=A0other= =C2=A0utilities=C2=A0and=C2=A0helpers=C2=A0for=C2=A0the=C2=A0most=C2=A0comm= on=C2=A0tasks. >=C2=A0 >=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 >=C2=A0 >= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0WWW:=C2=A0http://svgpp.org/ >=C2=A0 >= =C2=A0--- >=C2=A0 >=C2=A0=C2=A0graphics/Makefile=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0|=C2=A0=C2=A0=C2=A01=C2=A0+ >=C2=A0 >= =C2=A0=C2=A0graphics/svgpp/Makefile=C2=A0=C2=A0|=C2=A0=C2=A020=C2=A0+++++= >=C2=A0 >=C2=A0=C2=A0graphics/svgpp/distinfo=C2=A0=C2=A0|=C2=A0=C2= =A0=C2=A03=C2=A0+ >=C2=A0 >=C2=A0=C2=A0graphics/svgpp/pkg-descr=C2= =A0|=C2=A0=C2=A0=C2=A03=C2=A0+ >=C2=A0 >=C2=A0=C2=A0graphics/svgpp/pkg-= plist=C2=A0|=C2=A0192=C2=A0+++++++++++++++++++++++++++++++++++++++++++++++= >=C2=A0 >=C2=A0=C2=A05=C2=A0files=C2=A0changed,=C2=A0219=C2=A0insertio= ns(+) >=C2=A0 >=C2=A0diff=C2=A0--git=C2=A0a/graphics/Makefile=C2=A0b/gr= aphics/Makefile >=C2=A0 >=C2=A0index=C2=A08e12cafd0e4e..4a3bb391f03a= =C2=A0100644 >=C2=A0 >=C2=A0---=C2=A0a/graphics/Makefile >=C2=A0 >= =C2=A0+++=C2=A0b/graphics/Makefile >=C2=A0 >=C2=A0@@=C2=A0-1152,6=C2= =A0+1152,7=C2=A0@@ >=C2=A0 >=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0SUBDIR= =C2=A0+=3D=C2=A0svg2png >=C2=A0 >=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0SUBDIR=C2=A0+=3D=C2=A0svgalib >=C2=A0 >=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0SUBDIR=C2=A0+=3D=C2=A0svgbob >=C2=A0 >=C2=A0+=C2=A0=C2= =A0=C2=A0=C2=A0SUBDIR=C2=A0+=3D=C2=A0svgpp >=C2=A0 >=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0SUBDIR=C2=A0+=3D=C2=A0swappy >=C2=A0 >=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0SUBDIR=C2=A0+=3D=C2=A0swfmill >=C2=A0 >= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0SUBDIR=C2=A0+=3D=C2=A0swftools >= =C2=A0 >=C2=A0diff=C2=A0--git=C2=A0a/graphics/svgpp/Makefile=C2=A0b/graph= ics/svgpp/Makefile >=C2=A0 >=C2=A0new=C2=A0file=C2=A0mode=C2=A0100644= >=C2=A0 >=C2=A0index=C2=A0000000000000..505090385589 >=C2=A0 >= =C2=A0---=C2=A0/dev/null >=C2=A0 >=C2=A0+++=C2=A0b/graphics/svgpp/Makef= ile >=C2=A0 >=C2=A0@@=C2=A0-0,0=C2=A0+1,20=C2=A0@@ >=C2=A0 >=C2= =A0+PORTNAME=3D=C2=A0=C2=A0=C2=A0=C2=A0svgpp >=C2=A0 >=C2=A0+PORTVERSIO= N=3D=C2=A0=C2=A0=C2=A0=C2=A01.3.1 >=C2=A0 >=C2=A0+DISTVERSIONPREFIX=3D= =C2=A0=C2=A0=C2=A0=C2=A0v >=C2=A0 >=C2=A0+CATEGORIES=3D=C2=A0=C2=A0= =C2=A0=C2=A0graphics >=C2=A0 >=C2=A0+ >=C2=A0 >=C2=A0+MAINTAINER=3D= =C2=A0=C2=A0=C2=A0=C2=A0danfe@FreeBSD.org >=C2=A0 >=C2=A0+COMMENT=3D= =C2=A0=C2=A0=C2=A0=C2=A0C++=C2=A0header-only=C2=A0parsers=C2=A0for=C2=A0var= ious=C2=A0SVG=C2=A0syntaxes >=C2=A0 >=C2=A0+WWW=3D=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0http://svgpp.org/ >=C2=A0 >=C2=A0+ >= =C2=A0 >=C2=A0+LICENSE=3D=C2=A0=C2=A0=C2=A0=C2=A0BSL >=C2=A0 >=C2= =A0+LICENSE_FILE=3D=C2=A0=C2=A0=C2=A0=C2=A0${WRKSRC}/LICENSE_1_0.txt >= =C2=A0 >=C2=A0+ >=C2=A0 >=C2=A0+USE_GITHUB=3D=C2=A0=C2=A0=C2=A0=C2= =A0yes >=C2=A0 >=C2=A0+NO_BUILD=3D=C2=A0=C2=A0=C2=A0=C2=A0yes >=C2= =A0 >=C2=A0+NO_ARCH=3D=C2=A0=C2=A0=C2=A0=C2=A0yes >=C2=A0 >=C2=A0+ = >=C2=A0 >=C2=A0+do-install: >=C2=A0 >=C2=A0+=C2=A0=C2=A0=C2=A0=C2= =A0${CP}=C2=A0-a=C2=A0${WRKSRC}/include/=C2=A0${STAGEDIR}${PREFIX}/include= >=C2=A0 >=C2=A0+ >=C2=A0 >=C2=A0+.include=C2=A0=C2= =A0[http://bsd.port.mk>]; >=C2=A0 >=C2=A0... Hi, While this w= orks you can please consider to follow Porters Handbookregarding use of U= SE_GITHUB section (see examples) and COPYTREE_SHARE macro instead of cp f= or consistency? https://docs.freebsd.org/en/books/porters-handbook/boo= k/#makefile-master_sites-github https://docs.freebsd.org/en/books/port= ers-handbook/book/#install-copytree Best regards, Daniel --_=_swift_1717916905_bbe7bf6c18b832e61f3c1280c76e39f8_=_ Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: quoted-printable
On 2024-06-09T08:26:14.000+02:00, Alexey Dokuchaev <dan= fe@FreeBSD.org> wrote:


The branch main has bee=
n updated by danfe:


commit 187b9=
69b8f9f0ed850f0dc7eb8d08b6d961f1346
Author:     Alexey Dokuch=
aev <danf=
e@FreeBSD.org>
AuthorDate: 2024-06-09 06:25:00 +0000
Commit:     Alexey Dokuchaev <danfe@FreeBSD.org>
C=
ommitDate: 2024-06-09 06:25:00 +0000

    graph=
ics/svgpp: new port had been added (+)
    
   =
 SVG++ library can be thought of as a framework, containing parsers
    for various SVG syntaxes, adapters that simplify handling of par=
sed
    data, and other utilities and helpers for the most co=
mmon tasks.
    
---
 graphics/Makefile        |   1 +
 graphics/svgpp/Make=
file  |  20 +++++
 graphics/svgpp/distinfo  |   3 +
=

 graphics/svgpp/pkg-descr |   3 +
 graphics/svgpp/pkg-pl=
ist | 192 +++++++++++++++++++++++++++++++++++++++++++++++
 5 =
files changed, 219 insertions(+)

diff --git a/=
graphics/Makefile b/graphics/Makefile
index 8e12cafd0e4e..4a3=
bb391f03a 100644
--- a/graphics/Makefile
+++ b/=
graphics/Makefile
@@ -1152,6 +1152,7 @@
     SU=
BDIR +=3D svg2png
     SUBDIR +=3D svgalib
    =
 SUBDIR +=3D svgbob
+    SUBDIR +=3D svgpp
    =
 SUBDIR +=3D swappy
     SUBDIR +=3D swfmill
  =
   SUBDIR +=3D swftools
diff --git a/graphics/svgpp/Makefile =
b/graphics/svgpp/Makefile
new file mode 100644
=
index 000000000000..505090385589
--- /dev/null
=
+++ b/graphics/svgpp/Makefile
@@ -0,0 +1,20 @@
=
+PORTNAME=3D=09svgpp
+PORTVERSION=3D=091.3.1
+D=
ISTVERSIONPREFIX=3D=09v
+CATEGORIES=3D=09graphics
+
+MAINTAINER=3D=09danfe@FreeBSD.org
+COMMENT=3D=09C=
++ header-only parsers for various SVG syntaxes
+WWW=3D=09=09=
http://svgpp.org/
<=
/div>
+
+LICENSE=3D=09BSL
+LICENSE_FILE=3D=
=09${WRKSRC}/LICENSE_1_0.txt
+
+USE_GITHUB=3D=
=09yes
+NO_BUILD=3D=09yes
+NO_ARCH=3D=09yes
=

+
+do-install:
+=09${CP} -a ${WRKSRC=
}/include/ ${STAGEDIR}${PREFIX}/include
+
...
Hi,

While this works you can please consider to follow Por= ters Handbookregarding use of USE_GITHUB section (see examples) and COPYTRE= E_SHARE macro instead of cp for consistency?

<= a href=3D"https://docs.freebsd.org/en/books/porters-handbook/book/#makefile= -master_sites-github" target=3D"_blank" rel=3D"noopener noreferrer" data-ik= =3D"ik-secure">https://docs.freebsd.org/en/books/porters-handbook/book/#mak= efile-master_sites-github

=
Best regards,
Daniel
--_=_swift_1717916905_bbe7bf6c18b832e61f3c1280c76e39f8_=_--