From owner-svn-src-all@freebsd.org Tue Jul 14 22:48:31 2015 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 51F639A294B for ; Tue, 14 Jul 2015 22:48:31 +0000 (UTC) (envelope-from pfg@FreeBSD.org) Received: from nm35-vm5.bullet.mail.bf1.yahoo.com (nm35-vm5.bullet.mail.bf1.yahoo.com [72.30.238.77]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 013121194 for ; Tue, 14 Jul 2015 22:48:30 +0000 (UTC) (envelope-from pfg@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1436914103; bh=oTANcIYef3In0YRx9bRqFyGlZMAp7TgjMSJzDnWZsk0=; h=Date:From:To:CC:Subject:References:In-Reply-To:From:Subject; b=FnlsvQcyn91seHuxmYHTHs+sUvSS/Bfdt3U5V7U4OjOgnYGKFJR6Tt35DT5CVnVUOCyhBrM4gMzFgNr0gAFUlOfxfqgxuS6bBhqcDTVDoJXUZ5tNUHB+hLI9I11bS3DCsDXwft7nXSt75IXlFHhJiPUHJ33uYbwsSEd77PYedMl3S7965ifiVwsStrB0DMZiGCTe4PnaV3wyCOcEYZdaxMVimS9UaCCpDKtOwU5I02/D426lDvC67y+yr4lWmteQWf9uSRWGfriIfUXCVWfPVtM631qN1Y3bu8vzbdWovEu3cAVkMMxw8WDTevEYvipHn4NFDQQ19pl6bsfUPkKb1Q== Received: from [98.139.170.178] by nm35.bullet.mail.bf1.yahoo.com with NNFMP; 14 Jul 2015 22:48:23 -0000 Received: from [98.139.211.199] by tm21.bullet.mail.bf1.yahoo.com with NNFMP; 14 Jul 2015 22:48:23 -0000 Received: from [127.0.0.1] by smtp208.mail.bf1.yahoo.com with NNFMP; 14 Jul 2015 22:48:23 -0000 X-Yahoo-Newman-Id: 348794.30137.bm@smtp208.mail.bf1.yahoo.com X-Yahoo-Newman-Property: ymail-3 X-YMail-OSG: _9BMf1cVM1lTk7LmDHlrO2WxmPjTIUm.fsBvCF6sg3oUWZv iszBEA8xOHXEwVlfES3s8kJfFbF..c_Z7EPU2VMQA0PN5LHLW.0wAW7HQPYA RuOK7rvmFrdFgB2lg3XCwngcaA8d_Hxf3RPLzSv2PD2fh7impObwZw7Mz_3Z 0CSgBF4k4tuDad2JwsBTkVfto5Zvp_iXLmOY3UcdE.ZzWYr89hex3KQTmQ6t GkGts6s0D9V4gBPX2nJZpeHcqz_.xh4pr.OupH2WxPkp_wPyBvt8zH3yGM0S AaiKFRHsGmTz8YI2k.cMYNnlleLA_bZucXo9bPQPqugkcNHvQYfiEgFqQN32 YUPlSoLiv8JSCWfkQGm5SF4LR0YdDFdD2Iw8HcOijUi7WZan3x_2SEZIsLds M51q.9sJprNJ_R9ynG7dgN3VNOuM7F1kozMPuq8GQ1UlgYTlR2ckgPC6wHFt hFKwOjb57JMsoTrUE03VmkJcXAp2nyCMAYVfwL2RjrF10c5WxEbr64tsyU7b fp2ux2Bbt22YMTcuBwPfrUjAbJg.zk2Y_ X-Yahoo-SMTP: xcjD0guswBAZaPPIbxpWwLcp9Unf Message-ID: <55A591C8.1030105@FreeBSD.org> Date: Tue, 14 Jul 2015 17:48:40 -0500 From: Pedro Giffuni User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: d@delphij.net, Garrett Cooper , Baptiste Daroussin CC: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r285552 - head/usr.bin/xargs References: <201507141916.t6EJGEG1083928@repo.freebsd.org> <48222CD1-7087-4C9A-A586-71F6A37A601C@gmail.com> <55A574BA.4090700@delphij.net> In-Reply-To: <55A574BA.4090700@delphij.net> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Jul 2015 22:48:31 -0000 On 07/14/15 15:44, Xin Li wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA512 > > On 07/14/15 13:29, Garrett Cooper wrote: >> On Jul 14, 2015, at 12:16, Baptiste Daroussin >> wrote: >> >>> Author: bapt Date: Tue Jul 14 19:16:14 2015 New Revision: 285552 >>> URL: https://svnweb.freebsd.org/changeset/base/285552 >>> >>> Log: Convert atoi(3) to stronum(3) which allows to arguments and >>> report proper errors to the users >> Is strtonum preferred over strtoll, etc? > strtonum(3) is a wrapper of strtoll() and provides more functionality > like range checking, so I think the answer would be yes. There is only the issue that strtonum(3) is non-standard so I have resisted the temptation to blindly replace atoi(3) in existing code. Pedro.