From owner-svn-src-head@freebsd.org Fri Sep 1 16:56:05 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id E277DE1A667 for ; Fri, 1 Sep 2017 16:56:05 +0000 (UTC) (envelope-from ian@freebsd.org) Received: from pmta2.delivery6.ore.mailhop.org (pmta2.delivery6.ore.mailhop.org [54.200.129.228]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id C43F37F191 for ; Fri, 1 Sep 2017 16:56:05 +0000 (UTC) (envelope-from ian@freebsd.org) X-MHO-User: 398f8bb0-8f36-11e7-b49e-71a67e0dab63 X-Report-Abuse-To: https://support.duocircle.com/support/solutions/articles/5000540958-duocircle-standard-smtp-abuse-information X-Originating-IP: 73.78.92.27 X-Mail-Handler: DuoCircle Outbound SMTP Received: from ilsoft.org (unknown [73.78.92.27]) by outbound2.ore.mailhop.org (Halon) with ESMTPSA id 398f8bb0-8f36-11e7-b49e-71a67e0dab63; Fri, 01 Sep 2017 16:54:32 +0000 (UTC) Received: from rev (rev [172.22.42.240]) by ilsoft.org (8.15.2/8.15.2) with ESMTP id v81Gstk3001126; Fri, 1 Sep 2017 10:54:55 -0600 (MDT) (envelope-from ian@freebsd.org) Message-ID: <1504284895.41612.29.camel@freebsd.org> Subject: Re: svn commit: r323087 - in head/sys: amd64/conf arm64/conf i386/conf powerpc/conf riscv/conf sparc64/conf From: Ian Lepore To: cem@freebsd.org, Josh Paetzel Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Date: Fri, 01 Sep 2017 10:54:55 -0600 In-Reply-To: References: <201709011554.v81FssRG083114@repo.freebsd.org> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.18.5.1 FreeBSD GNOME Team Port Mime-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 Sep 2017 16:56:06 -0000 On Fri, 2017-09-01 at 09:06 -0700, Conrad Meyer wrote: > Wait, why?  The PR doesn't explain it any better than this commit > message. > > On Fri, Sep 1, 2017 at 8:54 AM, Josh Paetzel > wrote: > > > > Author: jpaetzel > > Date: Fri Sep  1 15:54:53 2017 > > New Revision: 323087 > > URL: https://svnweb.freebsd.org/changeset/base/323087 > > > > Log: > >   Take options IPSEC out of GENERIC > > > >   PR:   220170 > >   Submitted by: delphij > >   Reviewed by:  ae, glebius > >   MFC after:    2 weeks > >   Differential Revision:        D11806 The differential revision (which should be cited using the complete url in the commit) seems to indicate that it's because it can be kldloaded. This change misses the armv6 platform, where the option appears in std.armv6, which gets included in GENERIC (and all other armv6 configs). This change seems to warrant an entry in UPDATING, because it's going to catch a lot of people by surprise.  Even people with custom kernels, if they follow the advice of the handbook and "include GENERIC" then override things. -- Ian