From owner-freebsd-current@FreeBSD.ORG  Tue Oct 12 15:54:05 2004
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 2B7D216A4CE; Tue, 12 Oct 2004 15:54:05 +0000 (GMT)
Received: from ebb.errno.com (ebb.errno.com [66.127.85.87])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id C4DB443D49; Tue, 12 Oct 2004 15:54:04 +0000 (GMT)
	(envelope-from sam@errno.com)
Received: from [66.127.85.93] ([66.127.85.93])
	(authenticated bits=0)
	by ebb.errno.com (8.12.9/8.12.6) with ESMTP id i9CFs3Wi097250
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO);
	Tue, 12 Oct 2004 08:54:03 -0700 (PDT)
	(envelope-from sam@errno.com)
Message-ID: <416BFE30.2090308@errno.com>
Date: Tue, 12 Oct 2004 08:54:24 -0700
From: Sam Leffler <sam@errno.com>
Organization: Errno Consulting
User-Agent: Mozilla Thunderbird 0.8 (Macintosh/20040913)
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Gleb Smirnoff <glebius@freebsd.org>
References: <9256D57F598E6C41B288AA7DB94F29C902DFB963@pgnmail1.pgnaplikace.cz>
	<20041012140205.GD29433@cell.sick.ru>
In-Reply-To: <20041012140205.GD29433@cell.sick.ru>
Content-Type: text/plain; charset=KOI8-R; format=flowed
Content-Transfer-Encoding: 7bit
cc: freebsd-current@freebsd.org
Subject: Re: Broadcom bge and 802.1Q vlan tags
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 12 Oct 2004 15:54:05 -0000

Gleb Smirnoff wrote:
> On Tue, Oct 12, 2004 at 10:36:27AM +0200, Roub?cek Zdenek (T-Systems PragoNet) wrote:
> R>  I have run into a problem with my Broadcom NIC (Dell LATITUDE D600). I am not able to detect 802.1Q tags on incoming interface with ethereal or tcpdump. All incoming packets seems like they are not coming through trunk but as native ETH frames, ie. the vlan tag is missing, probably removed before being passed to tcpdump?
> R> 
> R> No I have not tested NIC's behaviour on 4.X, but I is working with linux (2.6.something kernel probably?)
> R> 
> R> Any ideas what to modify or set so I can detect vlan_tag would be very apreciated.
> 
> As Ruslan already mentioned, it is impossible to turn off hardware VLAN
> stripping in bge driver.
> 
> A patch to stop tagged frames to come on trunk interface is like this:
> 
> @@ -701,13 +657,16 @@
>          * see if the device performed the decapsulation and
>          * provided us with the tag.
>          */
> -       if (ifp->if_nvlans &&
> -           m_tag_locate(m, MTAG_VLAN, MTAG_VLAN_TAG, NULL) != NULL) {
> +       if (m_tag_locate(m, MTAG_VLAN, MTAG_VLAN_TAG, NULL) != NULL) {
>                 /*
>                  * vlan_input() will either recursively call ether_input()
>                  * or drop the packet.
>                  */
> -               KASSERT(vlan_input_p != NULL,("ether_input: VLAN not loaded!"));
> +               if (vlan_input_p == NULL) {
> +                       /* vlan(4) is not loaded, discard frame */
> +                       m_freem(m);
> +                       return;
> +               }
>                 (*vlan_input_p)(ifp, m);
>                 return;
>         }
> 

This pessimizes normal traffic.  We should look for a solution in the 
driver(s) to avoid sending packets up with tags when no vlans are 
configured.

	Sam