From owner-svn-src-head@FreeBSD.ORG  Thu Oct 16 23:00:06 2014
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 6AF6280C;
 Thu, 16 Oct 2014 23:00:06 +0000 (UTC)
Received: from cell.glebius.int.ru (glebius.int.ru [81.19.69.10])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "cell.glebius.int.ru", Issuer "cell.glebius.int.ru" (not verified))
 by mx1.freebsd.org (Postfix) with ESMTPS id DBDB7D18;
 Thu, 16 Oct 2014 23:00:05 +0000 (UTC)
Received: from cell.glebius.int.ru (localhost [127.0.0.1])
 by cell.glebius.int.ru (8.14.9/8.14.9) with ESMTP id s9GMxtQO088831
 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO);
 Fri, 17 Oct 2014 02:59:55 +0400 (MSK)
 (envelope-from glebius@FreeBSD.org)
Received: (from glebius@localhost)
 by cell.glebius.int.ru (8.14.9/8.14.9/Submit) id s9GMxtC5088830;
 Fri, 17 Oct 2014 02:59:55 +0400 (MSK)
 (envelope-from glebius@FreeBSD.org)
X-Authentication-Warning: cell.glebius.int.ru: glebius set sender to
 glebius@FreeBSD.org using -f
Date: Fri, 17 Oct 2014 02:59:55 +0400
From: Gleb Smirnoff <glebius@FreeBSD.org>
To: Dag-Erling =?iso-8859-1?Q?Sm=F8rgrav?= <des@des.no>
Subject: Re: svn commit: r272906 - in head/sys: conf libkern netpfil/pf sys
Message-ID: <20141016225955.GE73266@FreeBSD.org>
References: <201410101926.s9AJQRY1049602@svn.freebsd.org>
 <CA+q+Tcpt0zEbgu_LndZb4dzh=xykHvppeykuiG6P9cTJgDGeWw@mail.gmail.com>
 <20141015030455.GC73266@FreeBSD.org>
 <CAPyFy2CDSwLkTtPFj70tw2iuDam3rS4yFNri=pX0w7_58UYMoA@mail.gmail.com>
 <86wq81y9fz.fsf@nine.des.no>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <86wq81y9fz.fsf@nine.des.no>
User-Agent: Mutt/1.5.23 (2014-03-12)
Cc: src-committers <src-committers@freebsd.org>, Ed Maste <emaste@freebsd.org>,
 svn-src-all <svn-src-all@freebsd.org>,
 "George V. Neville-Neil" <gnn@freebsd.org>,
 Olivier =?iso-8859-1?Q?Cochard-Labb=E9?= <olivier@cochard.me>,
 svn-src-head <svn-src-head@freebsd.org>
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 16 Oct 2014 23:00:06 -0000

On Wed, Oct 15, 2014 at 11:21:52AM +0200, Dag-Erling Smørgrav wrote:
D> Ed Maste <emaste@freebsd.org> writes:
D> > murmur3's size argument is bytes, not uint32_ts, so the test is only
D> > hashing the first 1/4 of the keys.
D> 
D> That's my fault, and I'm going to change it, because it's illogical.
D> The function works on aligned arrays of int32s and should take a count,
D> not a size.  I just didn't want to delay the patch even further.

The function should also be documented in hash(9).

-- 
Totus tuus, Glebius.