From owner-freebsd-fs@FreeBSD.ORG  Thu Jan  7 01:20:04 2010
Return-Path: <owner-freebsd-fs@FreeBSD.ORG>
Delivered-To: freebsd-fs@hub.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 5608D1065670
	for <freebsd-fs@hub.freebsd.org>; Thu,  7 Jan 2010 01:20:04 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
	[IPv6:2001:4f8:fff6::28])
	by mx1.freebsd.org (Postfix) with ESMTP id 2C8A98FC1F
	for <freebsd-fs@hub.freebsd.org>; Thu,  7 Jan 2010 01:20:04 +0000 (UTC)
Received: from freefall.freebsd.org (localhost [127.0.0.1])
	by freefall.freebsd.org (8.14.3/8.14.3) with ESMTP id o071K4Zo010937
	for <freebsd-fs@freefall.freebsd.org>; Thu, 7 Jan 2010 01:20:04 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.14.3/8.14.3/Submit) id o071K4l8010935;
	Thu, 7 Jan 2010 01:20:04 GMT (envelope-from gnats)
Date: Thu, 7 Jan 2010 01:20:04 GMT
Message-Id: <201001070120.o071K4l8010935@freefall.freebsd.org>
To: freebsd-fs@FreeBSD.org
From: dfilter@FreeBSD.ORG (dfilter service)
Cc: 
Subject: Re: bin/138043: commit references a PR
X-BeenThere: freebsd-fs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: dfilter service <dfilter@FreeBSD.ORG>
List-Id: Filesystems <freebsd-fs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-fs>,
	<mailto:freebsd-fs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-fs>
List-Post: <mailto:freebsd-fs@freebsd.org>
List-Help: <mailto:freebsd-fs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-fs>,
	<mailto:freebsd-fs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 07 Jan 2010 01:20:04 -0000

The following reply was made to PR bin/138043; it has been noted by GNATS.

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: bin/138043: commit references a PR
Date: Thu,  7 Jan 2010 01:11:08 +0000 (UTC)

 Author: mckusick
 Date: Thu Jan  7 01:10:49 2010
 New Revision: 201708
 URL: http://svn.freebsd.org/changeset/base/201708
 
 Log:
   Add some error messages suggested in PR bin/138043. The code to
   correct the problem was added in r176575 by delphij on 2008-02-25.
   
   PR:		138043
   Reported by:	Heikki Suonsivu
 
 Modified:
   head/sbin/fsck_ffs/main.c
   head/sbin/fsck_ffs/pass1.c
 
 Modified: head/sbin/fsck_ffs/main.c
 ==============================================================================
 --- head/sbin/fsck_ffs/main.c	Thu Jan  7 00:57:40 2010	(r201707)
 +++ head/sbin/fsck_ffs/main.c	Thu Jan  7 01:10:49 2010	(r201708)
 @@ -406,7 +406,10 @@ checkfilesys(char *filesys)
  	 */
  	if (duplist) {
  		if (preen || usedsoftdep)
 -			pfatal("INTERNAL ERROR: dups with -p");
 +			pfatal("INTERNAL ERROR: dups with %s%s%s",
 +			    preen ? "-p" : "",
 +			    (preen && usedsoftdep) ? " and " : "",
 +			    usedsoftdep ? "softupdates" : "");
  		printf("** Phase 1b - Rescan For More DUPS\n");
  		pass1b();
  	}
 
 Modified: head/sbin/fsck_ffs/pass1.c
 ==============================================================================
 --- head/sbin/fsck_ffs/pass1.c	Thu Jan  7 00:57:40 2010	(r201707)
 +++ head/sbin/fsck_ffs/pass1.c	Thu Jan  7 01:10:49 2010	(r201708)
 @@ -98,10 +98,16 @@ pass1(void)
  			rebuildcg = 1;
  		if (!rebuildcg && sblock.fs_magic == FS_UFS2_MAGIC) {
  			inosused = cgrp.cg_initediblk;
 -			if (inosused > sblock.fs_ipg)
 +			if (inosused > sblock.fs_ipg) {
 +				pfatal("%s (%d > %d) %s %d\nReset to %d\n",
 +				    "Too many initialized inodes", inosused,
 +				    sblock.fs_ipg, "in cylinder group", c,
 +				    sblock.fs_ipg);
  				inosused = sblock.fs_ipg;
 -		} else
 +			}
 +		} else {
  			inosused = sblock.fs_ipg;
 +		}
  		if (got_siginfo) {
  			printf("%s: phase 1: cyl group %d of %d (%d%%)\n",
  			    cdevname, c, sblock.fs_ncg,
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"