From owner-freebsd-net@FreeBSD.ORG Thu Jun 21 09:21:50 2012 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id E247F1065675; Thu, 21 Jun 2012 09:21:50 +0000 (UTC) (envelope-from bms@fastmail.net) Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by mx1.freebsd.org (Postfix) with ESMTP id A0F378FC0C; Thu, 21 Jun 2012 09:21:50 +0000 (UTC) Received: from compute5.internal (compute5.nyi.mail.srv.osa [10.202.2.45]) by gateway1.nyi.mail.srv.osa (Postfix) with ESMTP id 7819621572; Thu, 21 Jun 2012 05:21:44 -0400 (EDT) Received: from frontend2.nyi.mail.srv.osa ([10.202.2.161]) by compute5.internal (MEProxy); Thu, 21 Jun 2012 05:21:44 -0400 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=fastmail.net; h= message-id:date:from:mime-version:to:cc:subject:references :in-reply-to:content-type:content-transfer-encoding; s=mesmtp; bh=E/LyY2RSb8DzivOJIypeCEoV+3U=; b=QniyWPUPH8MCyILrSsSaFgRJDcS9 CjNggjXB4sroGrLoYdLvCk8uFsznFfYbvQygY/wh0aXWGWJMmctsDOXPPmDg8khE LdjE9rxmIu2yQ72KeQhuGcojyD13VMi/GCK7ghyJJP77Gm7fgsRg2CgnzNTVEHa0 mPm15HnCVRd7RV8= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= messagingengine.com; h=message-id:date:from:mime-version:to:cc :subject:references:in-reply-to:content-type :content-transfer-encoding; s=smtpout; bh=E/LyY2RSb8DzivOJIypeCE oV+3U=; b=sEDW1l0crGCpSqHHhNO6ykEK9QEqw6EpvBakxIiu07le19dyqVLIVK WHk2569ugrGglgBVjXkR9H0fl/awVBrF4SkKkneID9zwFokggkX2sPaLBLKrVP7K ljzoDKqr3usyWOHGB8oKf1M3x4qOd3a5/ErlDEo+N6TJBD8EHY5rE= X-Sasl-enc: NfOslAZmsOT7wRujZlu8RwybQbfRwKo4i7YVAcPSlcLd 1340270504 Received: from [10.34.204.179] (unknown [193.62.251.36]) by mail.messagingengine.com (Postfix) with ESMTPA id CFA904836DD; Thu, 21 Jun 2012 05:21:43 -0400 (EDT) Message-ID: <4FE2E779.9040009@fastmail.net> Date: Thu, 21 Jun 2012 10:20:57 +0100 From: Bruce Simpson User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:13.0) Gecko/20120616 Thunderbird/13.0.1 MIME-Version: 1.0 To: Rui Paulo References: <36507982-766F-4AD3-96A3-6872B9F32793@felyko.com> In-Reply-To: <36507982-766F-4AD3-96A3-6872B9F32793@felyko.com> Content-Type: text/plain; charset=GB2312 Content-Transfer-Encoding: 7bit Cc: freebsd-net@freebsd.org, bms@freebsd.org, GuYong Subject: Re: Question about MLDv2 implemenation in Kernel X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Jun 2012 09:21:51 -0000 All, I'm working on something new just now,and am in a conference, but here is my 2p. On 20/06/12 22:20, Rui Paulo wrote: > On 20 Jun 2012, at 01:12, GuYong wrote: >> 1. RFC3810 clause 6.1 mentions there is a Source Retransmission Counter associated to each source, so that the merged report could contain the content that is interrupted by a new state change report BUT, I didn't see this is implemented currently! > I think this is stored in the mli_rv variable and decremented accordingly. Merging of pending state-changes is performed by mld_v2_merge_state_changes() and runs on a per-group basis for the end-station. mli_rv controls the retransmission report count. > I think you're right and it should be divided by MLD_TIMER_SCALE. ENOTIME to look into this further, but if someone sends me a working patch, I will review and commit. > My reading of it suggests that we are doing the right thing. We do > accept it and process it, but, like the text implies, we shouldn't > take any action. I concur. Bruce