From nobody Mon Mar 20 16:39:35 2023 X-Original-To: net@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4PgL6w1wfrz3yx8n for ; Mon, 20 Mar 2023 16:39:36 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4PgL6w0P2gz4CMj for ; Mon, 20 Mar 2023 16:39:36 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1679330376; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=lO46ESeuWGSqeLowPHlCmudHa7FaIswgcErKd/NhN2c=; b=AFSFcS30+uFETrtbU9jNkPWxlp56Bb2PUPX8o6Y9MnTgOlWQXV43OPpNSUWryVE+uzXfDt GSNw6XzhPVM46OXo/bO2vcND5rSJwNRXavZ0JQ6MRk7Jw99VKARDT9WQBcbTgE72uJ58qm ca/G16chk4DrbOE5ttr5SoFWr0D7clsV6JZ0vIlErJh9UN5sOeVGa1LIXqru1Dvu1eh0rX BNwGDwzjxMwqhuNY4LCCG25/nQGYy1toNfjMO+es0ntRvriLrJ4BNB0TztvmsAWEGfnRU3 HRSvNtdMUc6rm0UsRqfUL9Cn35PqEO71BGz/Mjd7l8oVHDXqNefM/GvQG0tvEg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1679330376; a=rsa-sha256; cv=none; b=eL0SCkfRMsH+Jzd3EteSPFbLmxkXTYH9nsk4KccDRbVwAMVQ2IIa2ZfOsga4ZlLHzHcncX NbUF9VQ9M+GzVd3MZVvzkqOBrY0GMyVFTmYzqUbeaSEmSvpOUjk10eaF5hKaOqOWibK3TY qgEDoowKorziAvtoYrgWag/AFUwK933iv1HIqD+8x9PmZNc0iN1whV4c01zlcJjAzuHh+f NlISCWX58bVH0YFaF/sB67wTWbtOGCpVlh068oRpIUgkyLtPrhNtrEE/wv6LLrpHkXLI9l uRfaOprZiLNMwXVerjP/8nRSXDjjneLpan7N2iD/AS4oXzA3SJGD/EzjU2Ow+Q== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4PgL6v6cbyzcXG for ; Mon, 20 Mar 2023 16:39:35 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 32KGdZ0K059188 for ; Mon, 20 Mar 2023 16:39:35 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from bugzilla@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 32KGdZM4059187 for net@FreeBSD.org; Mon, 20 Mar 2023 16:39:35 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: bugzilla set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: net@FreeBSD.org Subject: [Bug 268246] crash and panic using pfsync on 13.1-RELEASE Date: Mon, 20 Mar 2023 16:39:35 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 13.1-RELEASE X-Bugzilla-Keywords: crash, needs-qa X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: commit-hook@FreeBSD.org X-Bugzilla-Status: Closed X-Bugzilla-Resolution: FIXED X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: net@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Networking and TCP/IP with FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-net List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-net@freebsd.org MIME-Version: 1.0 X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D268246 --- Comment #94 from commit-hook@FreeBSD.org --- A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=3D53247cdf12449e90f6736ae563e4cce83= 15c923f commit 53247cdf12449e90f6736ae563e4cce8315c923f Author: Kristof Provost AuthorDate: 2023-03-20 13:29:55 +0000 Commit: Kristof Provost CommitDate: 2023-03-20 15:39:14 +0000 pfsync: fix pfsync_undefer_state() locking pfsync_undefer_state() takes the bucket lock, but could get called from places (e.g. from pfsync_update_state() or pfsync_delete_state()) where we already held the lock. As it can also be called from places where we don't yet hold the lock create new locked variant for use when the lock is already held. Keep using pfsync_undefer_state() where the lock must still be taken. PR: 268246 MFC after: 1 week Sponsored by: Rubicon Communications, LLC (Netgate) sys/netpfil/pf/if_pfsync.c | 22 ++++++++++++++++------ 1 file changed, 16 insertions(+), 6 deletions(-) --=20 You are receiving this mail because: You are the assignee for the bug.=