From owner-freebsd-current@FreeBSD.ORG  Wed May 28 08:05:27 2003
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 10CED37B401; Wed, 28 May 2003 08:05:27 -0700 (PDT)
Received: from salmon.maths.tcd.ie (salmon.maths.tcd.ie [134.226.81.11])
	by mx1.FreeBSD.org (Postfix) with SMTP
	id 9C38243F75; Wed, 28 May 2003 08:05:25 -0700 (PDT)
	(envelope-from dwmalone@maths.tcd.ie)
Received: from lanczos.maths.tcd.ie by salmon.maths.tcd.ie with SMTP
          id <aa61651@salmon>; 28 May 2003 16:05:24 +0100 (BST)
Date: Wed, 28 May 2003 16:05:24 +0100
From: David Malone <dwmalone@maths.tcd.ie>
To: Robert Watson <rwatson@FreeBSD.org>
Message-ID: <20030528150524.GA40895@lanczos.maths.tcd.ie>
References: <Pine.NEB.3.96L.1030528095854.51795A-100000@fledge.watson.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <Pine.NEB.3.96L.1030528095854.51795A-100000@fledge.watson.org>
User-Agent: Mutt/1.5.3i
Sender: dwmalone@maths.tcd.ie
cc: current@FreeBSD.org
Subject: Re: mb alloc and: panic: mutex Giant not owned at
	../../../vm/vm_kern.c:315
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 28 May 2003 15:05:27 -0000

On Wed, May 28, 2003 at 10:06:14AM -0400, Robert Watson wrote:
> I haven't seen this panic previously; a lack of Giant coming out of the
> socket code is a bit surprising to me, but I think is unlikely to be a
> result of our local MAC tweaks.

This may be my fault, as I made some changes recently that assumed
that the mbuf allocator grabbed giant when needed. I'll check the
code path you've mentioned to see if it grabs giant now, but I
suspect that I just need to move the giant grabbing back where it
was before.

	David.