From nobody Sun Jul 24 11:02:30 2022 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4LrKyH2CmRz4XXVh; Sun, 24 Jul 2022 11:02:31 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4LrKyH1PGNz3dcs; Sun, 24 Jul 2022 11:02:31 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1658660551; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=X+BVMAN4tcGYeanaNl9MI+9TMSyWjDvlRIlV6XEhIBc=; b=YFqkIe0vgSxQ69+4B0hrxy7AbnN61dC10HF+XBPvO6m6lSG0T3kB0W99mTfkSiXjCTrmNN cu6TDW0qj+ZsVUOKrf2MdA836ylGHwC4Gap1ZAeqOJBdOewdsfngkjSYc0Q85SI78/vKVg mH0EkJOvI8Ysz4b6DHdrSgJPyvQ3eFIc4qKRb994DaIXAWs0Ll5MSeWcQSeS8An0ouKYFr ItT1wiBoKbdY/dlC3mzuG0/pVTnjAVDPqYFq5d/J44F8A9GSYN+ND0XJfL/Gj7HF9vkIcw eWNu0jTzMc0FVTXPbNDmRRnUJ+0TsuZT42lO/fDQkF1+j0uEE7YMKnj/S1G5vQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4LrKyH0TrZzGcs; Sun, 24 Jul 2022 11:02:31 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 26OB2UaP041640; Sun, 24 Jul 2022 11:02:30 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 26OB2U1t041639; Sun, 24 Jul 2022 11:02:30 GMT (envelope-from git) Date: Sun, 24 Jul 2022 11:02:30 GMT Message-Id: <202207241102.26OB2U1t041639@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Dimitry Andric Subject: git: 037c0973366c - stable/12 - Adjust ipfw_iface_{init,destroy}() definitions to avoid clang 15 warning List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: dim X-Git-Repository: src X-Git-Refname: refs/heads/stable/12 X-Git-Reftype: branch X-Git-Commit: 037c0973366c29507ed5726e4842acfd49faa444 Auto-Submitted: auto-generated ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1658660551; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=X+BVMAN4tcGYeanaNl9MI+9TMSyWjDvlRIlV6XEhIBc=; b=pyxgq5sGMoF8acNjpmoYS6L3Q/2He1RRTlSL5HWBTzeWYUZY4IX0qbV/ZZiLYHp3CGOitI QcnToSU8lnMXl40rhJgbmg94WnV9oBo7E41Ml+d5yQQWWpFm8rcx8kaaJXadGZt8KJncfJ e25DTJqED2yuewCoZwkPjMVAzCiDYTCXt4Pn/17rNaqPTVOR+V1l1flKJ3j/8IA+BrHJE+ 2BUZu6nb3kiDUws/D15GoMA5EhjVy/SNABDieorVX5VEPPCNG/9jCM1udmE84T9FBpXZtW EjaA4hj8ETOhhoLwmIr720BI5Ylpkb2Jt8t1N9+pIXXAgRPYS+lSHjRjiX1L5w== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1658660551; a=rsa-sha256; cv=none; b=SdRyBWKmYrAoLjAN7d6CyPYEcumiEWtwsAqclyNgo7hPwOtPz0veMfCt1hSqi4CcGRowCp 0g0CGqDkAfSIW25fXQ+zyu1PIHVtBGNIYKa0A+1jC2v/seEqyTSc9tmYL6heLmFSWdY+LC 7Hn/+vs4k+6A2ayYmwK0jgCRrOFLYoJRHo2J777HdK82czANtx6vYOuaefkrB7bSN/CXkP EM5WHGN92j3ehD7JCrIjgNt7uOKQbYlWXtbpKu6mmClYRI2S6nYT6QAcXao2HJg7CooCku WiFszBfAr4sFGsnEvLHaXKDAJlpEL7rAnAdKmEXoLA24/IOIZ+ho/wqn4umU7g== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N The branch stable/12 has been updated by dim: URL: https://cgit.FreeBSD.org/src/commit/?id=037c0973366c29507ed5726e4842acfd49faa444 commit 037c0973366c29507ed5726e4842acfd49faa444 Author: Dimitry Andric AuthorDate: 2022-07-21 19:37:09 +0000 Commit: Dimitry Andric CommitDate: 2022-07-24 11:01:21 +0000 Adjust ipfw_iface_{init,destroy}() definitions to avoid clang 15 warning With clang 15, the following -Werror warnings are produced: sys/netpfil/ipfw/ip_fw_iface.c:206:16: error: a function declaration without a prototype is deprecated in all versions of C [-Werror,-Wstrict-prototypes] ipfw_iface_init() ^ void sys/netpfil/ipfw/ip_fw_iface.c:219:19: error: a function declaration without a prototype is deprecated in all versions of C [-Werror,-Wstrict-prototypes] ipfw_iface_destroy() ^ void This is because ipfw_iface_init() and ipfw_iface_destroy() are declared with (void) argument lists, but defined with empty argument lists. Make the definitions match the declarations. MFC after: 3 days (cherry picked from commit 1eea6b9097834484f2238298f550bb418901c313) --- sys/netpfil/ipfw/ip_fw_iface.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sys/netpfil/ipfw/ip_fw_iface.c b/sys/netpfil/ipfw/ip_fw_iface.c index 8b6b64727007..13b6bc4a8b45 100644 --- a/sys/netpfil/ipfw/ip_fw_iface.c +++ b/sys/netpfil/ipfw/ip_fw_iface.c @@ -204,7 +204,7 @@ ipfw_kiflookup(char *name) * mutex init. */ int -ipfw_iface_init() +ipfw_iface_init(void) { mtx_init(&vnet_mtx, "IPFW ifhandler mtx", NULL, MTX_DEF); @@ -217,7 +217,7 @@ ipfw_iface_init() * Unregister khandlers iff init has been done. */ void -ipfw_iface_destroy() +ipfw_iface_destroy(void) { IPFW_DEL_SOPT_HANDLER(1, scodes);