From owner-freebsd-current@FreeBSD.ORG  Thu Oct 16 09:43:47 2003
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 5FD3516A4B3
	for <current@freebsd.org>; Thu, 16 Oct 2003 09:43:47 -0700 (PDT)
Received: from postal2.es.net (postal2.es.net [198.128.3.206])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 8C74243F3F
	for <current@freebsd.org>; Thu, 16 Oct 2003 09:43:46 -0700 (PDT)
	(envelope-from oberman@es.net)
Received: from ptavv.es.net ([198.128.4.29])
        by postal2.es.net (Postal Node 2) with ESMTP (SSL) id MUA74016;
        Thu, 16 Oct 2003 09:43:45 -0700
Received: from ptavv (localhost [127.0.0.1])
	by ptavv.es.net (Tachyon Server) with ESMTP
	id 159285D0C; Thu, 16 Oct 2003 09:43:43 -0700 (PDT)
To: Hiroyuki Aizu <eyes@navi.org>
In-Reply-To: Message from Hiroyuki Aizu <eyes@navi.org> 
	<20031016231747.4f0640e3.eyes@navi.org> 
Date: Thu, 16 Oct 2003 09:43:42 -0700
From: "Kevin Oberman" <oberman@es.net>
Message-Id: <20031016164343.159285D0C@ptavv.es.net>
cc: current@freebsd.org
Subject: Re: PATCH for ATAng 
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 16 Oct 2003 16:43:47 -0000

> Date: Thu, 16 Oct 2003 23:17:47 +0900
> From: Hiroyuki Aizu <eyes@navi.org>
> Sender: owner-freebsd-current@freebsd.org
> 
> This is a multi-part message in MIME format.
> 
> --Multipart_Thu__16_Oct_2003_23_17_47_+0900_0865e200
> Content-Type: text/plain; charset=US-ASCII
> Content-Transfer-Encoding: 7bit
> 
> Hi.
> 
> The original ata_reset() lost ATA-master drive and remove main file system
> after suspend/resume. Of cource it occors panic!
> I think that the ata_reset() in ata-lowlevel.c is bogus and I can not
> understand the code. So I study ATA and rewrite ata_reset() completely.
> 
> New device detect algorism using ata command ATA_IDENTIFY_DEVICE and
> ATA_IDENTIFY_PACKET_DEVICE for judge ATA and ATAPI devices.
> 
> This patch works fine with my TOSHIBA Libretto L5. 
> But not yet test ATAPI devices and ATA-slave channel.
> Maybe there is need to adjust wait DELAY time.
> 
> Please test and replace ata_reset().
> 
> I hope this solve ATAng troubles.

I applied your patch and rebuilt my kernel on my ThinkPad T30 and the
behavior is changed, but not really improved.

Now, instead of hanging after "ata0: resetting devices .."
I now get:
ata0: Resetting devices ..
GEOM: destroy disk ad0 dp=0xc4945d70
ad0: WARNING - removed from configuration
done
ata1: resetting devices ..
ata1: check for dev existence:lsb=00 msb=00
ata1: check for dev existence:lsb=00 msb=00
done

I have only one ATA device which is master on ata0. (ad0).

Thanks for trying.
-- 
R. Kevin Oberman, Network Engineer
Energy Sciences Network (ESnet)
Ernest O. Lawrence Berkeley National Laboratory (Berkeley Lab)
E-mail: oberman@es.net			Phone: +1 510 486-8634