From owner-freebsd-current@FreeBSD.ORG Tue Nov 20 05:39:49 2007 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id AB85D16A41B for ; Tue, 20 Nov 2007 05:39:49 +0000 (UTC) (envelope-from jfvogel@gmail.com) Received: from nf-out-0910.google.com (nf-out-0910.google.com [64.233.182.188]) by mx1.freebsd.org (Postfix) with ESMTP id 19E7313C4D3 for ; Tue, 20 Nov 2007 05:39:48 +0000 (UTC) (envelope-from jfvogel@gmail.com) Received: by nf-out-0910.google.com with SMTP id b2so1651150nfb for ; Mon, 19 Nov 2007 21:39:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=beta; h=domainkey-signature:received:received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; bh=DkkGTn5Rg3Ldg5sSV8huR9q12ldCIWNRkoGLgvuE+Fc=; b=E/O0RChVbiKJ0uQCfwKYmEV832vVTXCWmocLfh4HDOy0Z1kvGaJ4e3FPL4idCYs7e3W9huIxibJhKcY9FPa/O+7u/xBRye9kZ2F6DRLwZjiRQd9O0qm0WqMf8VsAeRNL0Hkna6kCsXwdKJLx7DqECbxcDqTH0+apDRX2Ywda4nI= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=RZpGMmNgVVQD1PCpnFAAumaCXe20T3FB92O5CnVr+mSHhbeweGRyO9rUFYvu5VM2hu43g9TCYgeq26eEYgXaTr9R9Cgp09qRemlrSOtnQdUhC8yVz7+Tz7sPoey3BkKSWK+cOwVtHcOEK0s3MuNj+/6YwMZsxP1DbdoJIxM/EuM= Received: by 10.86.51.2 with SMTP id y2mr5801788fgy.1195537181436; Mon, 19 Nov 2007 21:39:41 -0800 (PST) Received: by 10.86.100.19 with HTTP; Mon, 19 Nov 2007 21:39:34 -0800 (PST) Message-ID: <2a41acea0711192139i5757df14h2796dcebf871213b@mail.gmail.com> Date: Mon, 19 Nov 2007 21:39:34 -0800 From: "Jack Vogel" To: "Mike Andrews" , re In-Reply-To: <20071118202733.S4351@mindcrime.int.bit0.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <20071117003504.R31357@mindcrime.int.bit0.com> <473F9552.50402@bit0.com> <473FBD1A.8010207@bit0.com> <20071118030305.N99375@mindcrime.int.bit0.com> <2a41acea0711181133n5f63f932m714a4a6b790937c0@mail.gmail.com> <2a41acea0711181140w6707b85p18ac9a483ae367b7@mail.gmail.com> <20071118181625.Y19404@mindcrime.int.bit0.com> <2a41acea0711181549m69a55283v852f8627e3217c61@mail.gmail.com> <20071118202733.S4351@mindcrime.int.bit0.com> Cc: Denis Shaposhnikov , Kip Macy , Mike Silbersack , Andre Oppermann , freebsd-current@freebsd.org Subject: Re: bizarre em + TSO + MSS issue in RELENG_7 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Nov 2007 05:39:49 -0000 Just to let everyone on the thread know, I have a fix for this problem that Mike just tested and confirmed. Its funny, its some crufty old code that has been in since I first got TSO working, it checks the packet len on entry to setup, and because I was always working with a standard mtu it had that hardcoded as a value less than which it would reject. I would like to update the 7 code anyway, howbout if I put in a new driver version to HEAD that includes this fix, and then MFC in a few days into REL, is there time before RELEASE or do i just need to spot fix this? Ken? Thanks for testing Mike, Jack