From owner-svn-ports-all@FreeBSD.ORG Sat Jan 25 10:31:20 2014 Return-Path: Delivered-To: svn-ports-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 788B0B54; Sat, 25 Jan 2014 10:31:20 +0000 (UTC) Received: from prod2.absolight.net (mx3.absolight.net [IPv6:2a01:678:2:100::25]) (using TLSv1 with cipher ADH-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 0EA20146B; Sat, 25 Jan 2014 10:31:19 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by prod2.absolight.net (Postfix) with ESMTP id 788ADBDC64; Sat, 25 Jan 2014 11:31:18 +0100 (CET) X-Virus-Scanned: amavisd-new at absolight.net X-Spam-Flag: NO X-Spam-Score: -3.027 X-Spam-Level: X-Spam-Status: No, score=-3.027 tagged_above=-200 required=5 tests=[AWL=-0.427, BAYES_00=-2.599, NO_RELAYS=-0.001] Received: by prod2.absolight.net (Postfix, from userid 1001) id 059F6BDC5D; Sat, 25 Jan 2014 11:31:18 +0100 (CET) Date: Sat, 25 Jan 2014 11:31:18 +0100 From: Mathieu Arnold To: Dmitry Marakasov Subject: Re: svn commit: r340875 - head/graphics/py-pyglet Message-ID: <20140125103117.GA72683@prod2.absolight.net> References: <201401240125.s0O1PcNR065306@svn.freebsd.org> <02676048890BF03180E6CFAB@atuin.in.mat.cc> <20140124124924.GF28542@hades.panopticon> <08A02A920829DC4130029A7F@ogg.in.absolight.net> <20140124173403.GA33026@hades.panopticon> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="HcAYCG3uE/tztfnV" Content-Disposition: inline In-Reply-To: <20140124173403.GA33026@hades.panopticon> User-Agent: Mutt/1.5.18 (2008-05-17) Cc: Mathieu Arnold , svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 25 Jan 2014 10:31:20 -0000 --HcAYCG3uE/tztfnV Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jan 24, 2014 at 09:34:04PM +0400, Dmitry Marakasov wrote: > * Mathieu Arnold (mat@FreeBSD.org) wrote: >=20 > > | I don't think that matters unless ${WRKSRC} is deleted in the > > | process. Actually, it's even better, as if for some reason some > > | command leaves something behind (a corefile or a log) in it's current > > | directory, it'll end up in ${WRKSRC} and to a ports' directory. > >=20 > > Well, yes, but no, you're missing the point, the idea is to have a stab= le > > and consistent way of doing things, so that if anyone needs to touch any > > port, (s)he doesn't have figure out what the current directory currentl= y is. >=20 > One should _never_ depend on current directory unless he changes > it in the same line. Because it's handling is (as you say) inconsistent > among make versions, and because it's highly error prone (changing > or reordering lines will break unrelated stuff). Also, all talk about > this is useless unless whole portstree is converted and then keept > consistent, which IHMO is completely useless. >=20 > > I was fine before because each line was executed in its own shell, but = now, > > the whole bloc is executed in one shell invocation. >=20 > Has this `now' happened in HEAD? >=20 > Both 9.0-RELEASE and 10.0-RELEASE (after bmake switch) behave like this: >=20 > % cat /tmp/Makefile=20 > all: > @pwd > @cd ..; pwd > @pwd > % make -C tmp > /tmp > / > /tmp >=20 > Although I remember having cd in one line affect pwd in another some > time ago. The thing is, the way it works depends on wether you do parallel building or not. $ make all /home/mat /home /home/mat $ make all -j 4 /home/mat /home /home And like I said, it's policy :-) --=20 Mathieu Arnold --HcAYCG3uE/tztfnV Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (FreeBSD) iQJ8BAABCgBmBQJS45J1XxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQzQUI2OTc4OUQyRUQxMjEwNjQ0MEJBNUIz QTQ1MTZGMzUxODNDRTQ4AAoJEDpFFvNRg85IccQP/15AuBBu+W56QvMMi5Ng816Q KNGx9VZS1MBkfLRRC5pGveNOIXyG1c1c2rJwTA/34zm7nuPX/AtWA8pXKR6+OdzB cf4t49vVRgAoSjCWR8EqY50agRZ9lx0uOqKZfm04pIx/r6z/FEJamefvBZK8oh+5 Wtokoe3sgGPvk1ljbZkrEHzruBaHIGPZlcOjwE0wFJhlrqwCaENpGGcFkJuDE8NN cst9FoH0yX2i1+Di3YX+d1EjHAH3cKAWjoy/wFfsAa31WSSMsD7OT3uD+A8/EKJv DddYsFGoo6A7QTf7s7HXSktyg50d1KTsnVsiUi0UcM1qm68Q/od+bhGbe6CAE9FG DsIC8kQ5pBO02XFZh2hRtgk4cHbLBvpGAOM1R7uhSgb2oOLV8ieI/0c5jwkmOAr7 6CdLfPimttkyLjrjlfcIg35o19vgV1Ig/RhKPag9+evCeziDdhmJXWr+Su2wKGIU rkXYXO8M3AeNmc3PTV2HRtsX9BMyWuzvz0jegzvzqSlZGnC28kZ/UVVL3NKStb9A uBz3OkwITTCNimJIiKqNyOtJ+mim5o/LLeRcx/oLaq/8RG0puRbM7wE9so5WM+/z 2L6zjMk8/WIbwP4wOdMXkAxpTWh/AQ0Fgdj9ZdWAEmHs5+maTXu6X+YNQhcbbJV8 8CqknFzRSxq39CSmITCM =nF3G -----END PGP SIGNATURE----- --HcAYCG3uE/tztfnV--