From owner-cvs-all Sun Nov 28 11:18:52 1999 Delivered-To: cvs-all@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 758) id 57AE414EAE; Sun, 28 Nov 1999 11:18:50 -0800 (PST) Received: from localhost (localhost [127.0.0.1]) by hub.freebsd.org (Postfix) with ESMTP id 4B4101CD741; Sun, 28 Nov 1999 11:18:50 -0800 (PST) (envelope-from kris@hub.freebsd.org) Date: Sun, 28 Nov 1999 11:18:50 -0800 (PST) From: Kris Kennaway To: Dan Moschuk Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/i386/conf files.i386 src/sys/kern kern_fork.c src/sys/libkern arc4random.c src/sys/sys libkern.h In-Reply-To: <199911281751.JAA40710@freefall.freebsd.org> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk On Sun, 28 Nov 1999, Dan Moschuk wrote: > Introduce OpenBSD-like Random PIDs. Controlled by a sysctl knob > (kern.randompid), which is currently defaulted off. Use ARC4 (RC4) for our > random number generation, which will not get me executed for violating > crypto laws; a Good Thing(tm). > > Reviewed and Approved by: bde, imp Reviewed and Not Approved by: kris. You're using a weak seeding mechanism and a handmade arc4 implementation which is not as good as the one we already have in libc. IMO, if you ask for a review and get objections, you should wait to address them before actually committing..otherwise, what's the point? > Revision Changes Path > 1.282 +2 -1 src/sys/i386/conf/files.i386 > 1.70 +6 -3 src/sys/kern/kern_fork.c > 1.19 +2 -1 src/sys/sys/libkern.h Plus. you seem to have failed to commit the arc4.c :-) Kris ---- Just remember, as you celebrate Thanksgiving with your family feasts of turkey, cranberries, stuffing, gravy, mashed potatoes, squash, corn, cornbread, apples, pickles, dumplings, fish, orangutans, fruitbats, breakfast cereals, and so forth, to keep in mind the true reason for the season: The birth of Santa. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message