From owner-freebsd-bugs@freebsd.org Mon Dec 21 17:13:52 2020 Return-Path: Delivered-To: freebsd-bugs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id F27214BFCAA for ; Mon, 21 Dec 2020 17:13:52 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (mailman.nyi.freebsd.org [IPv6:2610:1c1:1:606c::50:13]) by mx1.freebsd.org (Postfix) with ESMTP id 4D05fS6M6Bz3qrN for ; Mon, 21 Dec 2020 17:13:52 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id DA1B94BFAD7; Mon, 21 Dec 2020 17:13:52 +0000 (UTC) Delivered-To: bugs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id D9E014BFCA9 for ; Mon, 21 Dec 2020 17:13:52 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4D05fS5hK4z3r32 for ; Mon, 21 Dec 2020 17:13:52 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id B6565254BF for ; Mon, 21 Dec 2020 17:13:52 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 0BLHDqmj075867 for ; Mon, 21 Dec 2020 17:13:52 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 0BLHDqnN075866 for bugs@FreeBSD.org; Mon, 21 Dec 2020 17:13:52 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 252021] ichwd(4) does not clear the NO_REBOOT flag correctly on Lewisburg chipsets Date: Mon, 21 Dec 2020 17:13:52 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 12.2-RELEASE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: janm@transactionware.com X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Dec 2020 17:13:53 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D252021 Bug ID: 252021 Summary: ichwd(4) does not clear the NO_REBOOT flag correctly on Lewisburg chipsets Product: Base System Version: 12.2-RELEASE Hardware: amd64 OS: Any Status: New Severity: Affects Only Me Priority: --- Component: kern Assignee: bugs@FreeBSD.org Reporter: janm@transactionware.com Loading ichwd(4) on a Supermicro X11SPA-T motherboard with 12.2 gives this response: ichwd0: at port 0x400-0x41f iomem 0xfdc6000c-0xfdc6000f on isa0 ichwd0: ICH WDT present but disabled in BIOS or hardware The motherboard jumpers are enabled. In ichwd(4), Lewisburg is configured with TCO version 4. The Linux driver configures Lewisburg with TCO version 2. In src/sys/dev/ichwd/ichwd.c, ichwd_clear_noreboot() uses SMB_GC_NO_REBOOT (0x02) as the the mask for clearing the NO_REBOOT flag for TCO version 4 devices. Changing this mask to ICH_GCS_NO_REBOOT (0x20, as used in the TCO version 2 case) successfully clears the NO_REBOOT big on restart and makes the watchd= og work correctly. "TCO version" seems a bit overloaded here, I'm not exactly sure what a corr= ect fix should look like. --=20 You are receiving this mail because: You are the assignee for the bug.=