From nobody Mon Mar 16 19:44:50 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4fZQXl6sdYz6Vt7Z for ; Mon, 16 Mar 2026 19:44:55 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4fZQXl5bZsz43QR for ; Mon, 16 Mar 2026 19:44:55 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1773690295; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=CppJ7yDpz+FlTwiDYhd2u9QbYMhLGQyseFDJ38Fcd4E=; b=A+5wkrPsbobSXNJ66+3/G4RMzrHXzKTxHU9qmM2kCOfKMG/VMkV86FSSRkBB4cIU8FjTlw /4zjscRzo1a20Te1xepiGcpOUIg80TnTVtaGztlXoSNwHLSdBRUbBabnY/sa2WaqyULAxx a9KepTiD5d7FIvLdTTlhiJZ+fSBB0eMo1QiOtTwIHfUkRomV8RL+81hn348+UZyv8RgvkA up1hodwu/NZpMycJQNkQAv3uezr3giSs7ryx+7zylHt9KLr5xr8Y3JpFEt8OtavZpY0c8l 5mT2h3+ewm5/F4srUF7n2GuuloWUZkfJWP83tP+0OrxqzOyjnFBSTn+3mcQbEw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1773690295; a=rsa-sha256; cv=none; b=dYvLYRdl/UkziBWLAaRXJs6CcZIZuu00FQjTleV9j3DXHz1kiWbqG3YXv1aHnXOrtjS8ZJ oTAKYhsj/+XhV1Nvs4fZ360eMQfSJEDyTshBq5H17bde/s2SUhQvXPYGEwSjWwiK+DHYw8 qH8pdiT85NVqcMYGzE2MnAvpmGK+IV5VC1DdUSRJzqJnLxSAa6Pl1GqyJ3zVskKdrydlqr fhMtRhI+rRlGQeU3tGxNdZCRYET90mX0ACgjrR+ZWelTIMDjfM+TcdYRvp90P1AjDJziQ7 VJSCiOVbbK+BmjY8Hf6kszoXrEozvnZh8v7uM/0dL1m1VwlOZ+tnabmPDnIFFA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1773690295; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=CppJ7yDpz+FlTwiDYhd2u9QbYMhLGQyseFDJ38Fcd4E=; b=jn8gezR9yqjE9esWfaEdSnx/DLgqSwCNOtmi84EYybRCjI+BBj6aJ8b9IBR+hbiaTuEZUb bEO5qj1jbZeV1DgAXW+82WZR2D5y/n8ISkGXfECF3Tq2UbPyxHjwwETenXSBA9SibUgZVI mKsr0em0zOVB/cnF2difTcpK9LBSaIg13ENCRwxvTvcGOA7uV1mDY/tvdvRH/0V0vT/9pD J2FT6HNw8qv6LM9xdW635gbFQybbMzZW6fgsXy4lLQq7yVZjgxkqsYKI8NORla49bslRYy aL7SkKmYQA91uTikDMo4Qi+QLSlP6rS+5ylOxmGfOaCMR4sIvok6cKC+krS4WA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4fZQXl4gD8zq7g for ; Mon, 16 Mar 2026 19:44:55 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 3a892 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Mon, 16 Mar 2026 19:44:50 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Cc: Matt Delco From: Alexander Ziaee Subject: git: 4e3beef84628 - main - nvme: Removed unused 'regs' variable List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: ziaee X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 4e3beef84628ce6dfea7f053cddf3289fddf7794 Auto-Submitted: auto-generated Date: Mon, 16 Mar 2026 19:44:50 +0000 Message-Id: <69b85db2.3a892.16deee5e@gitrepo.freebsd.org> The branch main has been updated by ziaee: URL: https://cgit.FreeBSD.org/src/commit/?id=4e3beef84628ce6dfea7f053cddf3289fddf7794 commit 4e3beef84628ce6dfea7f053cddf3289fddf7794 Author: Matt Delco AuthorDate: 2026-03-10 19:30:51 +0000 Commit: Alexander Ziaee CommitDate: 2026-03-16 17:37:46 +0000 nvme: Removed unused 'regs' variable The private struct has a 'regs' member that's only written to and otherwise unused. This change removes it. Fixes: b3d9e5013f3e5 (Don't active memory space) Requested by: jhb Reviewed by: imp, jhb, jrtc27 Differential Revision: https://reviews.freebsd.org/D55817 --- sys/dev/nvme/nvme_ahci.c | 1 - sys/dev/nvme/nvme_pci.c | 1 - sys/dev/nvme/nvme_private.h | 2 -- 3 files changed, 4 deletions(-) diff --git a/sys/dev/nvme/nvme_ahci.c b/sys/dev/nvme/nvme_ahci.c index c50971f83975..8b3b6855bb62 100644 --- a/sys/dev/nvme/nvme_ahci.c +++ b/sys/dev/nvme/nvme_ahci.c @@ -79,7 +79,6 @@ nvme_ahci_attach(device_t dev) } ctrlr->bus_tag = rman_get_bustag(ctrlr->resource); ctrlr->bus_handle = rman_get_bushandle(ctrlr->resource); - ctrlr->regs = (struct nvme_registers *)ctrlr->bus_handle; /* Allocate and setup IRQ */ ctrlr->rid = 0; diff --git a/sys/dev/nvme/nvme_pci.c b/sys/dev/nvme/nvme_pci.c index 74191df52058..fa5a88844f92 100644 --- a/sys/dev/nvme/nvme_pci.c +++ b/sys/dev/nvme/nvme_pci.c @@ -225,7 +225,6 @@ nvme_ctrlr_allocate_bar(struct nvme_controller *ctrlr) ctrlr->bus_tag = rman_get_bustag(ctrlr->resource); ctrlr->bus_handle = rman_get_bushandle(ctrlr->resource); - ctrlr->regs = (struct nvme_registers *)ctrlr->bus_handle; return (0); } diff --git a/sys/dev/nvme/nvme_private.h b/sys/dev/nvme/nvme_private.h index 3dc62bc11384..95c38fe2e39e 100644 --- a/sys/dev/nvme/nvme_private.h +++ b/sys/dev/nvme/nvme_private.h @@ -286,8 +286,6 @@ struct nvme_controller { struct nvme_qpair adminq; struct nvme_qpair *ioq; - struct nvme_registers *regs; - struct nvme_controller_data cdata; struct nvme_namespace ns[NVME_MAX_NAMESPACES];