From owner-freebsd-multimedia  Sun Jul 13 13:10:27 1997
Return-Path: <owner-multimedia>
Received: (from root@localhost)
          by hub.freebsd.org (8.8.5/8.8.5) id NAA05519
          for multimedia-outgoing; Sun, 13 Jul 1997 13:10:27 -0700 (PDT)
Received: from rah.star-gate.com (rah.star-gate.com [204.188.121.18])
          by hub.freebsd.org (8.8.5/8.8.5) with ESMTP id NAA05513
          for <multimedia@freebsd.org>; Sun, 13 Jul 1997 13:10:22 -0700 (PDT)
Received: from rah.star-gate.com (localhost.star-gate.com [127.0.0.1])
	by rah.star-gate.com (8.8.5/8.8.5) with ESMTP id NAA07974;
	Sun, 13 Jul 1997 13:10:20 -0700 (PDT)
Message-Id: <199707132010.NAA07974@rah.star-gate.com>
X-Mailer: exmh version 2.0gamma 1/27/96
To: Randall Hopper <rhh@ct.picker.com>
cc: multimedia@freebsd.org
Subject: Re: guspnp9 feedback 
In-reply-to: Your message of "Sun, 13 Jul 1997 15:52:56 EDT."
             <19970713155256.41366@ct.picker.com> 
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Date: Sun, 13 Jul 1997 13:10:20 -0700
From: Amancio Hasty <hasty@rah.star-gate.com>
Sender: owner-multimedia@freebsd.org
X-Loop: FreeBSD.org
Precedence: bulk

In /sys/i386/isa/sound/sound_calls.h change the prototype from void to int:

/*  From awe_wave.c  */
int  attach_awe_obsolete(struct address_info *hw_config);

Recompile the kernel and please let us know if the driver works for you.

	Tnks,
	Amancio


>From The Desk Of Randall Hopper :
>      Had a few minutes to sit down and build the latest driver.  It appears
> that you changed some protos in sound_calls.h and didn't flow them to all
> the .c files.  attach looks like it now returns void rather than long and
> doesn't take a mem_start arg anymore.  
> 
>      Not knowing what the intent was, I'm not sure I'd make the right fix.
> Can you update the code and mail me the diffs.  Also, you might build a
> sound driver with all the devices compiled in.  That should be a pretty
> good build stress-test for the upcoming release.  (In particular, adding:
> 
> device awe0     at isa? port 0x620
> 
> will show the below problem.)
> 
> Thanks,
> 
> Randall
> 
> 
> cc -c -O -Wreturn-type -Wcomment -Wredundant-decls -Wimplicit  -Wnested-exter
ns -Wstrict-prototypes -Wmissing-prototypes  -Wpointer-arith  -nostdinc -I- -I.
 -I../.. -I/usr/include -DDEFAULT_CHNLSET=1 -DEXT2FS -DMSDOSFS -DCD9660 -DNFS -
DFFS -DINET -DCOMPAT_43 -DKERNEL  ../../i386/isa/sound/awe_wave.c
> ../../i386/isa/sound/awe_wave.c:428: warning: initialization from incompatibl
e pointer type
> ../../i386/isa/sound/awe_wave.c:450: conflicting types for `attach_awe_obsole
te'
> ../../i386/isa/sound/sound_calls.h:136: previous declaration of `attach_awe_o
bsolete'
> ../../i386/isa/sound/awe_wave.c:514: warning: no previous prototype for `unlo
ad_awe'
> *** Error code 1
> 
> Stop.